Skip to content

Send Idle message to actors when they are idle.#502

Merged
erikzhang merged 2 commits intomasterfrom
feature/idle_message
Dec 5, 2018
Merged

Send Idle message to actors when they are idle.#502
erikzhang merged 2 commits intomasterfrom
feature/idle_message

Conversation

@erikzhang
Copy link
Copy Markdown
Member

No description provided.

jsolman
jsolman previously approved these changes Dec 5, 2018
Copy link
Copy Markdown
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

Copy link
Copy Markdown
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question; suppose there is only one high priority message in the queue and no low priority messages, after the high priority one is processed it is idle, but idle message won’t be added. Is this the intent?

@erikzhang
Copy link
Copy Markdown
Member Author

One question; suppose there is only one high priority message in the queue and no low priority messages, after the high priority one is processed it is idle, but idle message won’t be added. Is this the intent?

fixed

Copy link
Copy Markdown
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@erikzhang erikzhang merged commit 7c8bf1f into master Dec 5, 2018
@erikzhang erikzhang deleted the feature/idle_message branch December 5, 2018 07:29
rodoufu pushed a commit to rodoufu/neo that referenced this pull request Mar 5, 2019
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants