Skip to content

[Fix] Release Packages Workflow (Docker, Binaries)#3938

Merged
NGDAdmin merged 4 commits intoneo-project:masterfrom
cschuchardt88:fix/workflow-release-leveldbstore
May 12, 2025
Merged

[Fix] Release Packages Workflow (Docker, Binaries)#3938
NGDAdmin merged 4 commits intoneo-project:masterfrom
cschuchardt88:fix/workflow-release-leveldbstore

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented May 9, 2025 •
edited
Loading

Description

Doesn't build LevelDbStore library as a portable dotnet binary. Since the release binary is native for the OS and changed the workflow to target the host OS native APIs.

Output

{C1FBE6AE-8B12-4CD5-B487-222C78827A30}

Remove Extra Libraries

{5F3D3164-043A-4D74-954C-D5571A1F4894}

Fixes #3936
Fixes #3935

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • My Github Workflow Actions

{8A56A845-02D5-452E-9189-292AC038A318}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 added Critical Issues (bugs) that need to be fixed ASAP GitHub Workflow Easy-to-Review a simple edit; just a few lines labels May 9, 2025
@shargon
Copy link
Member

shargon commented May 9, 2025

#3935 also?

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented May 9, 2025 •
edited
Loading

#3935 also?

yes

this on linux

image

@ixje
Copy link
Contributor

ixje commented May 9, 2025

In #3936 syncing works, but show state doesn't
In #3935 syncing doesn't work, but show state does.

They do not sound related at all. We haven't even identified the problem of #3935.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented May 9, 2025

In #3936 syncing works, but show state doesn't In #3935 syncing doesn't work, but show state does.

They do not sound related at all. We haven't even identified the problem of #3935.

Try with all plugins disabled, But LevelDbStore

Run for over 7 hours working fine

image

@ixje
Copy link
Contributor

ixje commented May 9, 2025 •
edited
Loading

We have a second 3.8.1 node running with TokensTracker, ApplicationLogs, SQLiteWallet, OracleService and StateService. That one is syncing fine (and is in sync). The difference there is that LevelDBStore and RpcServer are version 3.8.1.0 whereas the other plugins are 3.8.0.0 as that one upgraded from 3.8.0 to 3.8.1. The problematic node of #3935 went from 3.7.5 to 3.8.1 and has all plugin versions on 3.8.1.0. To make it even more obvious, the working 3.8.1 node with LevelDBStore version 3.8.1.0 even still has all the "useless" files in the LevelDBStore plugin folder (I didn't actually try using show state on that node). This just doesn't add up if you ask me.

Screenshot 2025-05-09 at 21 11 56

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented May 9, 2025 •
edited
Loading

We have a second 3.8.1 node running with TokensTracker, ApplicationLogs, SQLiteWallet, OracleService and StateService. That one is syncing fine (and is in sync). The difference there is that LevelDBStore and RpcServer are version 3.8.1.0 whereas the other plugins are 3.8.0.0 as that one upgraded from 3.8.0 to 3.8.1. The problematic node of #3935 went from 3.7.5 to 3.8.1 and has all plugin versions on 3.8.1.0. To make it even more obvious, the working 3.8.1 node with LevelDBStore version 3.8.1.0 even still has all the "useless" files in the LevelDBStore plugin folder (I didn't actually try using show state on that node). This just doesn't add up if you ask me.

Screenshot 2025-05-09 at 21 11 56

Those are good points. I been sick for about a month. I'm stilling digging into it. The only thing I can say is OS versions, drivers, hardware and/or workload on the different machines. We did enable some optimizations of dotnet features to speed up the offline syncing with the JIT.

-p:ServerGarbageCollection=true \
-p:TieredCompilation=true \
-p:TieredCompilationQuickJitForLoops=false \
-p:TieredPGO=true \

@NGDAdmin NGDAdmin merged commit bd75829 into neo-project:master May 12, 2025
11 of 13 checks passed
@Jim8y Jim8y deleted the fix/workflow-release-leveldbstore branch May 14, 2025 10:02
Jim8y pushed a commit to Jim8y/neo that referenced this pull request May 14, 2025
@cschuchardt88
[Fix] Release Packages Workflow (Docker, Binaries) (neo-project#3938)
9cf5166 
* Fix workflow

* Removed unused files

* removed unsed files from test folder

(cherry picked from commit bd75829)
This was referenced May 14, 2025
Closed
Closed
NGDAdmin pushed a commit that referenced this pull request May 15, 2025
@superboyiii @cschuchardt88
v3.8.2 (#3947)
ede620e 
* [`Fix`] Release Packages Workflow (Docker, Binaries) (#3938)

* Fix workflow

* Removed unused files

* removed unsed files from test folder

* v3.8.2

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
cschuchardt88 added a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@cschuchardt88
[Fix] Release Packages Workflow (Docker, Binaries) (neo-project#3938)
ad8767d 
* Fix workflow

* Removed unused files

* removed unsed files from test folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees

No one assigned

Labels

Critical Issues (bugs) that need to be fixed ASAP Easy-to-Review a simple edit; just a few lines GitHub Workflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

show state command doesn't work when restoring from chain file 3.8.1 node stuck with 100% CPU

6 participants

@cschuchardt88 @shargon @ixje @Jim8y @Wi1l-B0t @NGDAdmin