[Fix]: getnativecontract throws null reference exception if contract not active#3920
Merged
shargon merged 2 commits intoneo-project:masterfrom May 5, 2025
Merged
Conversation
Wi1l-B0t
commented
May 2, 2025
| { | ||
| JArray jArray = new(); | ||
| var validators = NativeContract.NEO.GetNextBlockValidators(snapshot, system.Settings.ValidatorsCount) ?? throw new RpcException(RpcError.InternalServerError.WithData("Can't get next block validators.")); | ||
| var validators = NativeContract.NEO.GetNextBlockValidators(snapshot, system.Settings.ValidatorsCount) |
Contributor
Author
There was a problem hiding this comment.
These lines are too long.
Member
There was a problem hiding this comment.
These changes are not related to the getnativecontracts problem, usually we use a separate PRs to fix this type of issues because it's a separate problem.
Contributor
Author
There was a problem hiding this comment.
These changes are not related to the
getnativecontractsproblem, usually we use a separate PRs to fix this type of issues because it's a separate problem.
Just add a '\n'
Wi1l-B0t
commented
May 2, 2025
| { | ||
| return new JArray(NativeContract.Contracts.Select(p => NativeContract.ContractManagement.GetContract(system.StoreView, p.Hash).ToJson())); | ||
| var storeView = system.StoreView; | ||
| var contractStates = NativeContract.Contracts |
AnnaShaleva
reviewed
May 3, 2025
| { | ||
| JArray jArray = new(); | ||
| var validators = NativeContract.NEO.GetNextBlockValidators(snapshot, system.Settings.ValidatorsCount) ?? throw new RpcException(RpcError.InternalServerError.WithData("Can't get next block validators.")); | ||
| var validators = NativeContract.NEO.GetNextBlockValidators(snapshot, system.Settings.ValidatorsCount) |
Member
There was a problem hiding this comment.
These changes are not related to the getnativecontracts problem, usually we use a separate PRs to fix this type of issues because it's a separate problem.
shargon
approved these changes
May 4, 2025
AnnaShaleva
approved these changes
May 4, 2025
Closed
cschuchardt88
pushed a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3917
Type of change
Checklist: