Skip to content

Avoid parallel UT#3903

Closed
shargon wants to merge 1 commit intomasterfrom
avoit-ut-parallel
Closed

Avoid parallel UT#3903
shargon wants to merge 1 commit intomasterfrom
avoit-ut-parallel

Conversation

@shargon
Copy link
Member

@shargon shargon commented Apr 17, 2025

Description

Sorry guys, but our tests was never done isolated at the begining, so if we want parallel unit tests, we should fix this before. #3874 was fault because of that, other test makes changes in HeadersCache, and other test consume it, and boom.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual test

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon added Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Waiting for Review labels Apr 17, 2025
@shargon shargon mentioned this pull request Apr 17, 2025
15 tasks
@Jim8y Jim8y added the NGD Review This pr is an UT/Benchmark PR, NGD can review. label Apr 17, 2025
@shargon
Copy link
Member Author

shargon commented Apr 17, 2025

I'm working in a different solution

@shargon shargon mentioned this pull request Apr 17, 2025
15 tasks
@shargon
Copy link
Member Author

shargon commented Apr 17, 2025

Closed y favor of #3904

@shargon shargon closed this Apr 17, 2025
@shargon shargon deleted the avoit-ut-parallel branch April 17, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. NGD Review This pr is an UT/Benchmark PR, NGD can review. Waiting for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants