[Neo Core UT] Test memory store#3336
Merged
shargon merged 3 commits intoneo-project:masterfrom Jun 20, 2024
Merged
Conversation
cschuchardt88
previously approved these changes
Jun 15, 2024
shargon
reviewed
Jun 15, 2024
Co-authored-by: Shargon <shargon@gmail.com>
vncoelho
reviewed
Jun 15, 2024
Member
vncoelho
left a comment
There was a problem hiding this comment.
Great Jimmy, I will check on Monday.
shargon
approved these changes
Jun 16, 2024
NGDAdmin
approved these changes
Jun 20, 2024
cschuchardt88
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously in #3288 i fixed the commit bug of datacache, and i though it was a problem of memorystore, but now i realized the real problem is
NeoSystem.StoreViewis actually a readonly store view and all stores are supposed not having a snapshot. Thus having this pr to further extend the test cases demonstrating howStoreViewandGetSnapshotworks.There is another issue that discoverd but not sure if it is designed to be so, which is the
seekmethod of memorystore and dadacache has different processing logic. Please check the updatedStoreTestandNeoSystemStoreGetAndChangeFixes #
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: