[Neo MemStore] fix memstore commit bug#3288
Merged
shargon merged 2 commits intoneo-project:masterfrom Jun 3, 2024
Merged
Conversation
cschuchardt88
approved these changes
Jun 1, 2024
shargon
approved these changes
Jun 3, 2024
vncoelho
reviewed
Jun 6, 2024
| } | ||
|
|
||
| [TestMethod] | ||
| public void NeoSystemStoreViewTest() |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the issue that when the neosystem is initialized with memstore, then called with
neoSystem.StoreView;, then the commit operation will fail as the snapshot isnull(snapshot = store as ISnapshot;gets null as memorystore isIStoreonly).exception:
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: