Skip to content

Fix error when vc_redist is missing#3293

Merged
shargon merged 3 commits intoneo-project:masterfrom
chenzhitong:vc_redist
Jun 7, 2024
Merged

Fix error when vc_redist is missing#3293
shargon merged 3 commits intoneo-project:masterfrom
chenzhitong:vc_redist

Conversation

@chenzhitong
Copy link
Contributor

close #3199

before:
image

after:
image

Jim8y
Jim8y previously approved these changes Jun 6, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Jun 6, 2024

I would say,,,, neo-cli is damaged, please download it from xxxxxx, instead of just handling a specific dll.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 6, 2024

I would compile the newest libleveldb yours is only 257kb and new one is 259kb maybe that is the problem. Also keep in mind, there is different versions of the dll for C++.

@shargon shargon merged commit 38cc0e9 into neo-project:master Jun 7, 2024
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 7, 2024
…negative-counter

* 'fix-negative-counter' of github.com:Jim8y/neo:
  Fix error when vc_redist is missing (neo-project#3293)
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 8, 2024
* 'fix-3300' of github.com:Jim8y/neo:
  Fix error when vc_redist is missing (neo-project#3293)
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 8, 2024
* master:
  Fix error when vc_redist is missing (neo-project#3293)
  Fixed up `main.yml` (neo-project#3292)
  [Neo Core Style] Rename parameters, update comments, fix code style (neo-project#3294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The release "neo-cli-win-x64.zip" can't run on Windows Server

5 participants