[Refactor] Appended Async to async methods names#3218
[Refactor] Appended Async to async methods names#3218cschuchardt88 wants to merge 22 commits intoneo-project:masterfrom
Refactor] Appended Async to async methods names#3218Conversation
shargon
left a comment
There was a problem hiding this comment.
We use reflection for smart contract methods names, this can't be done automatically
|
Yes i know, I added see below to fix that issue. Plus all tests checkout... because before I had problem with that. |
|
Why is this taking too long? |
Was this comment from @shargon solved or replied? |
I say resolved, because it's been tested with the |
| } | ||
|
|
||
| internal async void Invoke(ApplicationEngine engine, byte version) | ||
| internal async Task InvokeAsync(ApplicationEngine engine, byte version) |
There was a problem hiding this comment.
I'm worry in line 392, when we check that it must be a ContractTask and now some method returns Task
There was a problem hiding this comment.
I already tested this. Plus if it was void then it needs to be task. I also tried ContractTask and didn't work.
Change Log
Asyncto async methods names.editorconfigwith new rules, nothing in code changed besides above.Needs #3214 to work
Checklist: