Skip to content

[Refactor] Test Projects#3214

Merged
shargon merged 9 commits intoneo-project:masterfrom
cschuchardt88:refactor1
May 7, 2024
Merged

[Refactor] Test Projects#3214
shargon merged 9 commits intoneo-project:masterfrom
cschuchardt88:refactor1

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented May 6, 2024

Change Log

  • Refactor Test Projects

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you first remove the Directory.Build.props from tests, and now you recover it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 😢, This is to disable warnings and set coverlet.msbuild package. So i can clean up .github workflows.

@shargon shargon merged commit 8b3c59a into neo-project:master May 7, 2024
@shargon shargon deleted the refactor1 branch May 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants