Skip to content

Check script null in ContextItem#3198

Merged
shargon merged 1 commit intomasterfrom
core-fix-3197
Apr 19, 2024
Merged

Check script null in ContextItem#3198
shargon merged 1 commit intomasterfrom
core-fix-3197

Conversation

@shargon
Copy link
Member

@shargon shargon commented Apr 18, 2024

Close #3197

@shargon shargon requested a review from superboyiii April 18, 2024 08:34
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, maybe add some UT? @shargon

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 18, 2024
Ensure that ParameterContext's Item with nil script can be properly
marshalled. Ref. neo-project/neo#3198.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@shargon shargon merged commit 629baf8 into master Apr 19, 2024
@shargon shargon deleted the core-fix-3197 branch April 19, 2024 07:30
AliceInHunterland pushed a commit to nspcc-dev/neo-go that referenced this pull request Apr 22, 2024
Ensure that ParameterContext's Item with nil script can be properly
marshalled. Ref. neo-project/neo#3198.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContractParametersContext.ToJson() hasn't checked Script is null or not before Convert.ToBase64String(Script)

5 participants