Conversation
12 tasks
AnnaShaleva
reviewed
Apr 8, 2024
Member
AnnaShaleva
left a comment
There was a problem hiding this comment.
The fix itself looks legit, let me check it in tests.
shargon
commented
Apr 8, 2024
AnnaShaleva
approved these changes
Apr 8, 2024
Member
There was a problem hiding this comment.
BTW, this PR is more related to #3178 than to #3175. It's an interesting fact that Notary contract is the first user of generic native contract tasks; all other contracts just use non-generic version that doesn't left anything on stack.
LGTM, tested with Notary contract and Check_ExpirationOf unit-test, works as expected:
anna@kiwi:~/Documents/GitProjects/neo-project/neo$ dotnet test --filter Check_ExpirationOf
Determining projects to restore...
All projects are up-to-date for restore.
Neo.Json -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.Json/bin/Debug/netstandard2.1/Neo.Json.dll
Neo.Extensions -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.Extensions/bin/Debug/netstandard2.1/Neo.Extensions.dll
Neo.ConsoleService -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.ConsoleService/bin/Debug/netstandard2.1/Neo.ConsoleService.dll
Neo.VM -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.VM/bin/Debug/netstandard2.1/Neo.VM.dll
Neo.Json -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.Json/bin/Debug/net8.0/Neo.Json.dll
Neo.IO -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.IO/bin/Debug/netstandard2.1/Neo.IO.dll
Neo.Cryptography.BLS12_381 -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.Cryptography.BLS12_381/bin/Debug/net8.0/Neo.Cryptography.BLS12_381.dll
Neo.VM -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.VM/bin/Debug/net8.0/Neo.VM.dll
Neo.ConsoleService -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.ConsoleService/bin/Debug/net8.0/Neo.ConsoleService.dll
Neo.Extensions -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.Extensions/bin/Debug/net8.0/Neo.Extensions.dll
Neo.Json.UnitTests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.Json.UnitTests/bin/Debug/net8.0/Neo.Json.UnitTests.dll
Neo.VM.Benchmarks -> /home/anna/Documents/GitProjects/neo-project/neo/benchmarks/Neo.VM.Benchmarks/bin/Debug/net8.0/Neo.VM.Benchmarks.dll
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.Json.UnitTests/bin/Debug/net8.0/Neo.Json.UnitTests.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Neo.Cryptography.BLS12_381 -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.Cryptography.BLS12_381/bin/Debug/netstandard2.1/Neo.Cryptography.BLS12_381.dll
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Neo.VM.Tests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.VM.Tests/bin/Debug/net8.0/Neo.VM.Tests.dll
Neo.Cryptography.BLS12_381.Tests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.Cryptography.BLS12_381.Tests/bin/Debug/net8.0/Neo.Cryptography.BLS12_381.Tests.dll
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.VM.Tests/bin/Debug/net8.0/Neo.VM.Tests.dll (.NETCoreApp,Version=v8.0)
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.Cryptography.BLS12_381.Tests/bin/Debug/net8.0/Neo.Cryptography.BLS12_381.Tests.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Neo.IO -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.IO/bin/Debug/net8.0/Neo.IO.dll
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Neo.ConsoleService.Tests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.ConsoleService.Tests/bin/Debug/net8.0/Neo.ConsoleService.Tests.dll
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.ConsoleService.Tests/bin/Debug/net8.0/Neo.ConsoleService.Tests.dll (.NETCoreApp,Version=v8.0)
No test matches the given testcase filter `Check_ExpirationOf` in /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.Json.UnitTests/bin/Debug/net8.0/Neo.Json.UnitTests.dll
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
No test matches the given testcase filter `Check_ExpirationOf` in /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.VM.Tests/bin/Debug/net8.0/Neo.VM.Tests.dll
No test matches the given testcase filter `Check_ExpirationOf` in /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.Cryptography.BLS12_381.Tests/bin/Debug/net8.0/Neo.Cryptography.BLS12_381.Tests.dll
No test matches the given testcase filter `Check_ExpirationOf` in /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.ConsoleService.Tests/bin/Debug/net8.0/Neo.ConsoleService.Tests.dll
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs(46,116): warning CS1570: XML comment has badly formed XML -- 'Missing equals sign between attribute and attribute value.' [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs(46,119): warning CS1570: XML comment has badly formed XML -- 'Missing equals sign between attribute and attribute value.' [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs(46,124): warning CS1570: XML comment has badly formed XML -- 'Missing equals sign between attribute and attribute value.' [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/NeoSystem.cs(119,59): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/NeoSystem.cs(119,91): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/NeoSystem.cs(131,91): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/ProtocolSettings.cs(123,39): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Persistence/StoreFactory.cs(39,33): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Cryptography/Helper.cs(163,36): warning SYSLIB0053: 'AesGcm.AesGcm(byte[])' is obsolete: 'AesGcm should indicate the required tag size for encryption and decryption. Use a constructor that accepts the tag size.' (https://aka.ms/dotnet-warnings/SYSLIB0053) [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Cryptography/Helper.cs(191,36): warning SYSLIB0053: 'AesGcm.AesGcm(byte[])' is obsolete: 'AesGcm should indicate the required tag size for encryption and decryption. Use a constructor that accepts the tag size.' (https://aka.ms/dotnet-warnings/SYSLIB0053) [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/SmartContract/IInteroperable.cs(38,53): warning SYSLIB0050: 'FormatterServices' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' (https://aka.ms/dotnet-warnings/SYSLIB0050) [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/SmartContract/Native/Notary.cs(112,17): warning CS0219: The variable 'verified' is assigned but its value is never used [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs(46,116): warning CS1570: XML comment has badly formed XML -- 'Missing equals sign between attribute and attribute value.' [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs(46,119): warning CS1570: XML comment has badly formed XML -- 'Missing equals sign between attribute and attribute value.' [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs(46,124): warning CS1570: XML comment has badly formed XML -- 'Missing equals sign between attribute and attribute value.' [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/ProtocolSettings.cs(123,39): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/NeoSystem.cs(119,59): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/NeoSystem.cs(119,91): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/NeoSystem.cs(131,91): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Persistence/StoreFactory.cs(39,33): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/SmartContract/Native/Notary.cs(112,17): warning CS0219: The variable 'verified' is assigned but its value is never used [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo/Neo.csproj::TargetFramework=netstandard2.1]
Neo -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo/bin/Debug/net8.0/Neo.dll
Neo -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo/bin/Debug/netstandard2.1/Neo.dll
Neo.CLI -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.CLI/bin/Debug/net8.0/neo-cli.dll
Neo.Benchmarks -> /home/anna/Documents/GitProjects/neo-project/neo/benchmarks/Neo.Benchmarks/bin/Debug/net8.0/Neo.Benchmarks.dll
GUI/MainForm.resx : warning MSB3825: Resource "listView1.Groups" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.resx : warning MSB3825: Resource "listView1.Groups1" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.resx : warning MSB3825: Resource "listView1.Groups2" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.es-ES.resx : warning MSB3825: Resource "listView1.Groups" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.es-ES.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.es-ES.resx : warning MSB3825: Resource "listView1.Groups1" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.es-ES.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.es-ES.resx : warning MSB3825: Resource "listView1.Groups2" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.es-ES.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.zh-Hans.resx : warning MSB3825: Resource "listView1.Groups" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.zh-Hans.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.zh-Hans.resx : warning MSB3825: Resource "listView1.Groups1" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.zh-Hans.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.zh-Hans.resx : warning MSB3825: Resource "listView1.Groups2" of type "System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" is deserialized via BinaryFormatter at runtime. BinaryFormatter is deprecated due to possible security risks and will be removed with .NET 9. If you wish to continue using it, set property "GenerateResourceWarnOnBinaryFormatterUse" to false. [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
GUI/MainForm.zh-Hans.resx : warning MSB3825: More information: https://aka.ms/msbuild/net8-binaryformatter [/home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/Neo.GUI.csproj::TargetFramework=net8.0-windows]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(13,7): warning CS0105: The using directive for 'FluentAssertions' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(15,7): warning CS0105: The using directive for 'Microsoft.VisualStudio.TestTools.UnitTesting' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(18,7): warning CS0105: The using directive for 'Neo.IO' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(20,7): warning CS0105: The using directive for 'Neo.Network.P2P.Payloads' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(22,7): warning CS0105: The using directive for 'Neo.Persistence' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(24,7): warning CS0105: The using directive for 'Neo.SmartContract' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(26,7): warning CS0105: The using directive for 'Neo.SmartContract.Native' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(28,7): warning CS0105: The using directive for 'Neo.UnitTests.Extensions' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(32,7): warning CS0105: The using directive for 'System' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(33,7): warning CS0105: The using directive for 'System' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(36,7): warning CS0105: The using directive for 'System.Linq' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(38,7): warning CS0105: The using directive for 'System.Numerics' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_GasToken.cs(39,7): warning CS0105: The using directive for 'System.Numerics' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(13,7): warning CS0105: The using directive for 'FluentAssertions' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(15,7): warning CS0105: The using directive for 'Microsoft.VisualStudio.TestTools.UnitTesting' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(18,7): warning CS0105: The using directive for 'Neo.IO' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(20,7): warning CS0105: The using directive for 'Neo.Network.P2P.Payloads' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(22,7): warning CS0105: The using directive for 'Neo.Persistence' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(24,7): warning CS0105: The using directive for 'Neo.SmartContract' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(26,7): warning CS0105: The using directive for 'Neo.SmartContract.Native' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(28,7): warning CS0105: The using directive for 'Neo.UnitTests.Extensions' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(30,7): warning CS0105: The using directive for 'Neo.VM' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(33,7): warning CS0105: The using directive for 'System' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(34,7): warning CS0105: The using directive for 'System' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(37,7): warning CS0105: The using directive for 'System.Linq' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(39,7): warning CS0105: The using directive for 'System.Numerics' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(40,7): warning CS0105: The using directive for 'System.Numerics' appeared previously in this namespace [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(68,17): warning CS0219: The variable 'defaultNotaryServiceFeePerKey' is assigned but its value is never used [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs(103,17): warning CS0219: The variable 'defaultNotaryServiceFeePerKey' is assigned but its value is never used [/home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/Neo.UnitTests.csproj::TargetFramework=net8.0]
Neo.UnitTests -> /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll
Neo.GUI -> /home/anna/Documents/GitProjects/neo-project/neo/src/Neo.GUI/bin/Debug/net8.0-windows/Neo.GUI.dll
Test run for /home/anna/Documents/GitProjects/neo-project/neo/tests/Neo.UnitTests/bin/Debug/net8.0/Neo.UnitTests.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Passed! - Failed: 0, Passed: 1, Skipped: 0, Total: 1, Duration: 331 ms - Neo.UnitTests.dll (net8.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3175