Conversation
Jim8y
previously approved these changes
Feb 28, 2024
shargon
commented
Mar 5, 2024
AnnaShaleva
reviewed
Mar 5, 2024
AnnaShaleva
approved these changes
Mar 6, 2024
Member
AnnaShaleva
left a comment
There was a problem hiding this comment.
The PR itself LGTM. Is it expected that Windows tests are failing? The reason seems not to be connected with this PR:
2024-03-06T08:04:08.6498402Z Neo.CLI -> D:\a\neo\neo\src\Neo.CLI\bin\Debug\net7.0\neo-cli.dll
2024-03-06T08:04:09.9259426Z Neo.UnitTests -> D:\a\neo\neo\tests\Neo.UnitTests\bin\Debug\net7.0\Neo.UnitTests.dll
2024-03-06T08:04:09.9332130Z Test run for D:\a\neo\neo\tests\Neo.UnitTests\bin\Debug\net7.0\Neo.UnitTests.dll (.NETCoreApp,Version=v7.0)
2024-03-06T08:04:09.9973775Z Microsoft (R) Test Execution Command Line Tool Version 17.7.2 (x64)
2024-03-06T08:04:09.9975436Z Copyright (c) Microsoft Corporation. All rights reserved.
2024-03-06T08:04:10.0002537Z
2024-03-06T08:04:10.1081193Z Starting test execution, please wait...
2024-03-06T08:04:10.1354227Z A total of 1 test files matched the specified pattern.
2024-03-06T08:04:12.3442822Z Failed TestCreateAccount [35 ms]
2024-03-06T08:04:12.3443427Z Error Message:
2024-03-06T08:04:12.3443861Z Assert.IsTrue failed.
2024-03-06T08:04:12.3444283Z Stack Trace:
2024-03-06T08:04:12.3445530Z at Neo.UnitTests.Wallets.NEP6.UT_NEP6Wallet.TestCreateAccount() in D:\a\neo\neo\tests\Neo.UnitTests\Wallets\NEP6\UT_NEP6Wallet.cs:line 94
2024-03-06T08:04:12.3447557Z at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
2024-03-06T08:04:12.3449197Z at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
2024-03-06T08:04:12.3450058Z
2024-03-06T08:04:26.9255779Z
2024-03-06T08:04:26.9306468Z Failed! - Failed: 1, Passed: 704, Skipped: 0, Total: 705, Duration: 16 s - Neo.UnitTests.dll (net7.0)
Member
Author
looks like we have undeterministic error in wallets, but not related to this PR, we need to find the issue in a different pr... |
AliceInHunterland
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Mar 19, 2024
Port neo-project/neo#3170. Close #3346 Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #3145 (comment)
We don't need to do some verification on each
ContractStatedeserialization, it was already checked during deploy and update.Type of change