Update: list all existing pligins when checking plugin list, not just installed by Jim8y · Pull Request #3080 · neo-project/neo

Jim8y · 2024-01-10T12:04:39Z

This pr update the plugins command.

In the past, this command only list the local installed plugins, now it also list other plugins avaliable for neo-cli.

The reason for adding this pr is because the plugins name is hard to remember, yet checking them have to go to the github release log.

Jim8y · 2024-01-10T12:05:09Z

cschuchardt88 · 2024-01-10T12:20:07Z

Can you fix the alignment (padding)?

Jim8y · 2024-01-10T12:26:26Z

Can you fix the alignment (padding)?

what format you think is better?

src/Neo.CLI/CLI/MainService.Plugins.cs

Co-authored-by: Shargon <shargon@gmail.com>

shargon · 2024-01-10T14:48:13Z

I like the idea :)

cschuchardt88 · 2024-01-10T19:37:48Z

Move over the names so they are aligned with each other and maybe put `not installed` and have it `grayed out text`. Also add the `plugin` descriptions if possible.

Jim8y · 2024-01-11T01:53:51Z

Jim8y · 2024-01-11T01:54:42Z

But we can't get description for uninstalled, its contained within the plugins.

cschuchardt88 · 2024-01-11T04:40:04Z

src/Neo.CLI/CLI/MainService.Plugins.cs

                    if (installedPlugin.Length == 1)
                    {
                        var plugin = $"(installed) {p}";
+                        plugin = plugin.PadLeft(25);


You can do something like this for padding in dotnet like it's easier and cleaner. $"(Installed) {p, 25}"

shargon · 2024-01-11T06:26:39Z

But we can't get description for uninstalled, its contained within the plugins.

Then it's better like this:

Installed:

xxxx
-xxxx
-Availables:
xxxx, yyyy, zzzz,...

shargon · 2024-01-11T06:30:13Z

label string
An alternate short description of the asset. Used in place of the filename.

We are not filling this field, but we can add a short description to the asset

cschuchardt88 · 2024-01-11T07:42:40Z

label string
An alternate short description of the asset. Used in place of the filename.

We are not filling this field, but we can add a short description to the asset

@Jim8y We can add a json manifest file on github to download? With plugin information in it.

Jim8y · 2024-01-11T07:46:01Z

Another thing.

cschuchardt88 · 2024-01-11T07:49:42Z

@Jim8y if you need help, I can help

Jim8y · 2024-01-11T07:51:44Z

@Jim8y if you need help, I can help

It not about that, just not a thing this pr tries to work. Manifest maybe, not this pr.

shargon · 2024-01-11T08:20:24Z

label string
An alternate short description of the asset. Used in place of the filename.

We are not filling this field, but we can add a short description to the asset

@Jim8y We can add a json manifest file on github to download? With plugin information in it.

It's a good idea

Jim8y · 2024-01-11T08:22:09Z

Manifest is a manifest of plugins, which is not in this repo yet. Good idea or not. It's another thing. And I don't think downloading a file directly from the source is a good thing.

cschuchardt88 · 2024-01-11T08:26:00Z

Manifest is a manifest of plugins, which is not in this repo yet. Good idea or not. It's another thing. And I don't think downloading a file directly from the source is a good thing.

It would be published to the Release? We download plugins from github. Why not? Or even better. have manifest with-in the neo-cli directory. Same as config.json or add it to config.json. Also have download link Url be configurable. So we can target PRs

Jim8y · 2024-01-11T08:50:00Z

I don't want discuss it in this pr. This pr only focus on solve a simple issue which is the name of all plugins. Yes, we may get description from somewhere, it is another task.

Jim8y · 2024-01-11T08:51:08Z

I find the issue and open the pr cause I need it now to debug the existing system, waiting for a release takes too long.

shargon

We can add the description when it's available

cschuchardt88 · 2024-01-11T09:54:11Z

We can add the description when it's available

@shargon we should have a config file. Reason is for testing. https://api.github.com/repos/neo-project/neo-modules/releases is hard code. You know how easy it will be to test PRs. @vncoelho may want this configurable.

shargon · 2024-01-11T14:22:12Z

We can add the description when it's available

@shargon we should have a config file. Reason is for testing. https://api.github.com/repos/neo-project/neo-modules/releases is hard code. You know how easy it will be to test PRs. @vncoelho may want this configurable.

I hate hardcoded values, so for me It's good to move to settings.

vncoelho · 2024-01-11T14:23:10Z

We can add the description when it's available

@shargon we should have a config file. Reason is for testing. https://api.github.com/repos/neo-project/neo-modules/releases is hard code. You know how easy it will be to test PRs. @vncoelho may want this configurable.

I hate hardcoded values, so for me It's good to move to settings.

Exactly, especially if the application has other plugins list

Jim8y · 2024-01-13T04:41:52Z

@shargon

shargon · 2024-01-13T05:33:30Z

We can improve it later, when we upload the manifest in modules

…to specify-log-exception * 'specify-log-exception' of github.com:Liaojinghui/neo: Update: list all existing pligins when checking plugin list, not just installed (neo-project#3080)

Jim8y and others added 2 commits January 10, 2024 20:02

list all existing pligins when checking plugin list, not just installed

eb8ec66

Merge branch 'master' into update-plugin-list

a54d695

shargon reviewed Jan 10, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

Update MainService.Plugins.cs

854c001

Co-authored-by: Shargon <shargon@gmail.com>

Merge branch 'master' into update-plugin-list

7d4b786

Jim8y and others added 2 commits January 11, 2024 09:53

udate format

340d0d0

Merge branch 'master' into update-plugin-list

e5ca78c

cschuchardt88 reviewed Jan 11, 2024

View reviewed changes

shargon added 2 commits January 11, 2024 10:41

Clean notifications and code

9a87cfc

Merge branch 'master' into update-plugin-list

32d750e

shargon approved these changes Jan 11, 2024

View reviewed changes

Jimmy added 2 commits January 11, 2024 23:21

Merge branch 'master' into update-plugin-list

3206220

Merge branch 'master' into update-plugin-list

c75aef7

shargon merged commit a478329 into neo-project:master Jan 13, 2024

cschuchardt88 mentioned this pull request Jan 25, 2024

[neo-cli]: Plugin(s) Download Config File & Bug Fixes & Output Formatting #3092

Merged

12 tasks

roman-khimov added this to the v3.7.0 milestone Feb 27, 2024

Conversation

Jim8y commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jim8y commented Jan 10, 2024

Uh oh!

cschuchardt88 commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jim8y commented Jan 10, 2024

Uh oh!

Uh oh!

shargon commented Jan 10, 2024

Uh oh!

cschuchardt88 commented Jan 10, 2024

Move over the names so they are aligned with each other and maybe put not installed and have it grayed out text. Also add the plugin descriptions if possible.

Uh oh!

Jim8y commented Jan 11, 2024

Uh oh!

Jim8y commented Jan 11, 2024

Uh oh!

cschuchardt88 Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shargon commented Jan 11, 2024

Uh oh!

shargon commented Jan 11, 2024

Uh oh!

cschuchardt88 commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jim8y commented Jan 11, 2024

Uh oh!

cschuchardt88 commented Jan 11, 2024

Uh oh!

Jim8y commented Jan 11, 2024

Uh oh!

shargon commented Jan 11, 2024

Uh oh!

Jim8y commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cschuchardt88 commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jim8y commented Jan 11, 2024

Uh oh!

Jim8y commented Jan 11, 2024

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

cschuchardt88 commented Jan 11, 2024

Uh oh!

shargon commented Jan 11, 2024

Uh oh!

vncoelho commented Jan 11, 2024

Uh oh!

Jim8y commented Jan 13, 2024

Uh oh!

shargon commented Jan 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jim8y commented Jan 10, 2024 •

edited

Loading

cschuchardt88 commented Jan 10, 2024 •

edited

Loading

Move over the names so they are aligned with each other and maybe put `not installed` and have it `grayed out text`. Also add the `plugin` descriptions if possible.

cschuchardt88 Jan 11, 2024 •

edited

Loading

cschuchardt88 commented Jan 11, 2024 •

edited

Loading

Jim8y commented Jan 11, 2024 •

edited

Loading

cschuchardt88 commented Jan 11, 2024 •

edited

Loading