Patch checkabi#2884
Merged
shargon merged 5 commits intoneo-project:check-abi-for-notificationsfrom Aug 9, 2023
Merged
Conversation
shargon
approved these changes
Aug 9, 2023
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 10, 2023
Follow the neo-project/neo#2884. A part of the neo-project/neo#2810. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 10, 2023
Follow the neo-project/neo#2884. A part of the neo-project/neo#2810. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
shargon
added a commit
that referenced
this pull request
Aug 18, 2023
* Check ABI for notifications * Patch checkabi (#2884) * Remove extra space (#2878) * Add Hardfork for StrictMode (#2881) * init * rename * hardfork * Update ApplicationEngine.Runtime.cs --------- Co-authored-by: Shargon <shargon@gmail.com> * Check UTF8 string * Cleaner way * Fix Buffer * Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs Co-authored-by: Anna Shaleva <anna@nspcc.ru> --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Shine Li <bfshm@qq.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Anna Shaleva <anna@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 18, 2023
Follow the neo-project/neo#2884. A part of the neo-project/neo#2810. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 18, 2023
Follow the neo-project/neo#2884. A part of the neo-project/neo#2810. Fix failing tests along the way (a lot of them have invalid notifications format which differs from the one declared in manifest). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add hardfork.