Interop syscall for current tx signers by shargon · Pull Request #2827 · neo-project/neo

shargon · 2022-10-27T08:52:05Z

Close #2825

shargon · 2022-10-27T08:56:34Z

@roman-khimov please take a look to this version

src/Neo/Network/P2P/Payloads/Transaction.cs

erikzhang · 2022-10-28T05:41:32Z

I prefer to add a new syscall.

shargon · 2022-10-30T09:50:19Z

I prefer to add a new syscall.

GetTransactionSigners was extended, create a new one only for the current tx, seems weird to me :S

shargon · 2023-07-05T08:16:07Z

@neo-project/core what do you think about this change? now is not possible to check the signers of the current transaction, and this could be important for certain cases

Jim8y · 2023-07-05T11:31:51Z

@neo-project/core what do you think about this change? now is not possible to check the signers of the current transaction, and this could be important for certain cases

I am with @erikzhang on this. Maybe we should give it another syscall, cause current transaction may not actually be a part of the ledger.

vncoelho · 2023-07-05T11:37:09Z

Maybe one advantage of a new syscall is also to avoid problems during resync. @shargon , is this 100% compatible? Maybe state could change,no?

Jim8y · 2023-07-05T11:38:29Z

Maybe one advantage of a new syscall is also to avoid problems during resync. @shargon , is this 100% compatible? Maybe state could change,no?

A good question, if they called this on current tx before, this will change the state.

superboyiii · 2023-07-06T10:13:05Z

@shargon I think add a new one is better to avoid data incompatible.

AnnaShaleva · 2023-07-06T10:20:14Z

Just FYI, I've checked the compatibility with current mainnet up to 3722380 height using this patch applied to 0.101.2 (latest 3.5.0-compatible release) with NeoGo node, it doesn't produce a fork:

diff --git a/pkg/core/native/ledger.go b/pkg/core/native/ledger.go
index 51734c226..9b1f9bddc 100644
--- a/pkg/core/native/ledger.go
+++ b/pkg/core/native/ledger.go
@@ -154,6 +154,13 @@ func (l *Ledger) getTransactionFromBlock(ic *interop.Context, params []stackitem
 
 // getTransactionSigners returns transaction signers to the SC.
 func (l *Ledger) getTransactionSigners(ic *interop.Context, params []stackitem.Item) stackitem.Item {
+       hash, err := getUint256FromItem(params[0])
+       if err != nil {
+               panic(err)
+       }
+       if tx, ok := ic.Container.(*transaction.Transaction); ok && tx.Hash().Equals(hash) {
+               return SignersToStackItem(tx.Signers)
+       }
        tx, h, err := getTransactionAndHeight(ic.DAO, params[0])
        if err != nil || !isTraceableBlock(ic, h) {
                return stackitem.Null{}

Synced NeoGo node log:

...
2023-07-06T13:14:41.522+0300	INFO	node reached synchronized state, starting services
2023-07-06T13:14:41.522+0300	INFO	starting state validation service
2023-07-06T13:14:41.522+0300	INFO	RPC server already started
2023-07-06T13:14:43.654+0300	INFO	persisted to disk	{"blocks": 0, "keys": 2, "headerHeight": 3722380, "blockHeight": 3722380, "took": "2.419533ms"}
2023-07-06T13:14:55.668+0300	INFO	persisted to disk	{"blocks": 1, "keys": 24, "headerHeight": 3722381, "blockHeight": 3722381, "took": "9.178084ms"}
2023-07-06T13:14:59.665+0300	INFO	persisted to disk	{"blocks": 0, "keys": 2, "headerHeight": 3722381, "blockHeight": 3722381, "took": "4.620791ms"}
...

States check result:

anna@kiwi:~/Documents/GitProjects/nspcc-dev/neo-go$ go run scripts/compare-states/compare-states.go http://localhost:10332 http://seed1.neo.org:10332
at 0: bb2bd2dfee742024b966cdf757c6235044cb9e0ce43497ad0eb27c49b8bdf4fe vs bb2bd2dfee742024b966cdf757c6235044cb9e0ce43497ad0eb27c49b8bdf4fe
at 3722380: ec321406a353f5906a049ebb034b72b8aeaeb7e07658d1bf6a8e84c0a7ba20ad vs ec321406a353f5906a049ebb034b72b8aeaeb7e07658d1bf6a8e84c0a7ba20ad

Although I'm not sure about T5 testnet.

AnnaShaleva · 2023-07-06T10:51:05Z

I've checked compatibility of this patch with T5 testnet as far, it's compatible up to 2306990:

...
2023-07-06T13:44:37.606+0300	INFO	node reached synchronized state, starting services
2023-07-06T13:44:37.606+0300	INFO	RPC server already started
2023-07-06T13:44:37.606+0300	INFO	starting state validation service
2023-07-06T13:44:53.741+0300	WARN	peer disconnected	{"addr": "65.108.90.74:21333", "error": "handling CMDExtensible message: invalid height", "peerCount": 12}
2023-07-06T13:45:18.242+0300	INFO	persisted to disk	{"blocks": 1, "keys": 23, "headerHeight": 2297514, "blockHeight": 2297514, "took": "1m31.495449456s"}
2023-07-06T13:45:24.609+0300	INFO	persisted to disk	{"blocks": 9474, "keys": 246120, "headerHeight": 2306988, "blockHeight": 2306988, "took": "6.366979915s"}
2023-07-06T13:45:25.617+0300	INFO	persisted to disk	{"blocks": 1, "keys": 23, "headerHeight": 2306989, "blockHeight": 2306989, "took": "5.461234ms"}
2023-07-06T13:45:26.619+0300	INFO	persisted to disk	{"blocks": 0, "keys": 2, "headerHeight": 2306989, "blockHeight": 2306989, "took": "7.163001ms"}
2023-07-06T13:45:38.647+0300	INFO	persisted to disk	{"blocks": 1, "keys": 23, "headerHeight": 2306990, "blockHeight": 2306990, "took": "27.762326ms"}
2023-07-06T13:45:43.625+0300	INFO	persisted to disk	{"blocks": 0, "keys": 2, "headerHeight": 2306990, "blockHeight": 2306990, "took": "2.693429ms"}
2023-07-06T13:45:53.633+0300	INFO	persisted to disk	{"blocks": 1, "keys": 23, "headerHeight": 2306991, "blockHeight": 2306991, "took": "5.431817ms"}
...

The states comparison result:

anna@kiwi:~/Documents/GitProjects/nspcc-dev/neo-go$ go run scripts/compare-states/compare-states.go http://localhost:20332 http://seed1t5.neo.org:20332
at 0: 9c1361fbbe2a0ce31910f992cbdfb8afee6f178e5d1aabdd1c6f2af90440e239 vs 9c1361fbbe2a0ce31910f992cbdfb8afee6f178e5d1aabdd1c6f2af90440e239
at 2306990: f40800cc2da50ce3934795711d07d1bedf01ea91ab6de487cfad155a7f09cc89 vs f40800cc2da50ce3934795711d07d1bedf01ea91ab6de487cfad155a7f09cc89

So technically if nothinig breaking happens after the checked heights, this PR can be merged as is (without new interop).

However, we have #2873 that makes 3.6 incompatible with T5.

src/Neo/SmartContract/ApplicationEngine.Runtime.cs

tests/Neo.UnitTests/SmartContract/UT_InteropService.cs

Port the neo-project/neo#2827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

superboyiii · 2023-07-12T06:29:14Z

@vncoelho Could you have a review?

vncoelho · 2023-07-12T10:44:39Z

Sure, I will review asap

Co-authored-by: Jimmy <jinghui@wayne.edu>

superboyiii · 2023-07-13T08:51:39Z

@shargon We need modify signer.cs

Otherwise will throw null exception

shargon · 2023-08-24T08:09:40Z

@shargon We need modify signer.cs Otherwise will throw null exception

Could you send me the error?

Jim8y · 2023-08-29T12:11:02Z

@superboyiii @shargon Lets move on to finish this

shargon · 2023-08-31T13:32:49Z

@superboyiii @shargon Lets move on to finish this

I'm waiting for @superboyiii , I didn't have this error

ProDog · 2023-09-11T07:14:54Z

When make the transaction, we need to calculate GasConsumed with InvokeScript in RpcClient, and AllowedContracts/AllowedGroups/Rules is null in RpcServer, so it will throw null exception.

https://github.com/neo-project/neo-modules/blob/09c2879958a916e0867fc78c64a04edfabe6935f/src/RpcServer/RpcServer.SmartContract.cs#L172-L174

Need to fix the RpcServer!

superboyiii

Good to merge.

Port the neo-project/neo#2827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Allow current tx signers

7872d4b

shargon requested a review from erikzhang October 27, 2022 08:52

roman-khimov reviewed Oct 27, 2022

View reviewed changes

src/Neo/Network/P2P/Payloads/Transaction.cs Outdated Show resolved Hide resolved

Allow current tx

0e31cf4

Merge branch 'master' into current-signers

62a1848

shargon mentioned this pull request Jul 5, 2023

StrictMode during contract deploy/update will break the T5 after 3.6 release #2873

Closed

Jim8y approved these changes Jul 5, 2023

View reviewed changes

Change syscall

96d5399

shargon requested review from Jim8y and roman-khimov July 6, 2023 14:21

Jim8y previously approved these changes Jul 6, 2023

View reviewed changes

Jim8y reviewed Jul 6, 2023

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.Runtime.cs Outdated Show resolved Hide resolved

Jim8y reviewed Jul 6, 2023

View reviewed changes

tests/Neo.UnitTests/SmartContract/UT_InteropService.cs Outdated Show resolved Hide resolved

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Jul 8, 2023

core: add System.Runtime.CurrentSigners syscall

88ae0d7

Port the neo-project/neo#2827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva mentioned this pull request Jul 8, 2023

core: support System.Runtime.CurrentSigners syscall nspcc-dev/neo-go#3058

Merged

1 task

AnnaShaleva approved these changes Jul 12, 2023

View reviewed changes

shargon dismissed Jim8y’s stale review via 4037570 July 12, 2023 14:23

Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs

4037570

Co-authored-by: Jimmy <jinghui@wayne.edu>

Jimmy added 2 commits July 12, 2023 22:48

Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs

2cc08f4

Update tests/Neo.UnitTests/SmartContract/UT_InteropService.cs

e6856c5

Jim8y previously approved these changes Jul 12, 2023

View reviewed changes

vncoelho changed the title ~~Allow current tx signers~~ Interop syscall for current tx signers Jul 12, 2023

vncoelho previously approved these changes Jul 12, 2023

View reviewed changes

Merge branch 'master' into current-signers

5d2e482

shargon dismissed stale reviews from vncoelho and Jim8y via 5d2e482 August 24, 2023 08:06

dotnet format

c773f77

shargon and others added 2 commits August 24, 2023 10:19

Add UT

05ed7da

Merge branch 'master' into current-signers

d6c1635

Merge branch 'master' into current-signers

4e32f0a

Merge branch 'master' into current-signers

3f9f810

Jim8y approved these changes Sep 4, 2023

View reviewed changes

shargon and others added 2 commits September 4, 2023 12:37

Merge branch 'master' into current-signers

e374540

Merge branch 'master' into current-signers

f75143c

superboyiii approved these changes Sep 13, 2023

View reviewed changes

Ashuaidehao mentioned this pull request Sep 13, 2023

Fix invoke signer neo-project/neo-modules#821

Merged

shargon closed this in neo-project/neo-modules#821 Sep 13, 2023

shargon reopened this Sep 13, 2023

shargon merged commit 5bccb94 into master Sep 13, 2023

shargon deleted the current-signers branch September 13, 2023 10:41

shargon mentioned this pull request Sep 15, 2023

Update Neo neo-project/neo-devpack-dotnet#793

Merged

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Nov 20, 2023

core: add System.Runtime.CurrentSigners syscall

2fba044

Port the neo-project/neo#2827. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

mialbu mentioned this pull request Dec 1, 2023

[Neo v3.6.2] Add new syscall currentSigners neow3j/neow3j#994

Closed

Conversation

shargon commented Oct 27, 2022

Uh oh!

shargon commented Oct 27, 2022

Uh oh!

Uh oh!

erikzhang commented Oct 28, 2022

Uh oh!

shargon commented Oct 30, 2022

Uh oh!

shargon commented Jul 5, 2023

Uh oh!

Jim8y commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vncoelho commented Jul 5, 2023

Uh oh!

Jim8y commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

superboyiii commented Jul 6, 2023

Uh oh!

AnnaShaleva commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnnaShaleva commented Jul 6, 2023

Uh oh!

Uh oh!

Uh oh!

superboyiii commented Jul 12, 2023

Uh oh!

vncoelho commented Jul 12, 2023

Uh oh!

superboyiii commented Jul 13, 2023

Uh oh!

shargon commented Aug 24, 2023

Uh oh!

Jim8y commented Aug 29, 2023

Uh oh!

shargon commented Aug 31, 2023

Uh oh!

ProDog commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

superboyiii left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Jim8y commented Jul 5, 2023 •

edited

Loading

Jim8y commented Jul 5, 2023 •

edited

Loading

AnnaShaleva commented Jul 6, 2023 •

edited

Loading

ProDog commented Sep 11, 2023 •

edited

Loading