Conversation
roman-khimov
left a comment
There was a problem hiding this comment.
Anyone tested it already wrt mainnet compatibility?
| /// Calculates corresponding account scripthash for the given public key. | ||
| /// </summary> | ||
| public static readonly InteropDescriptor System_Contract_CreateStandardAccount = Register("System.Contract.CreateStandardAccount", nameof(CreateStandardAccount), 1 << 8, CallFlags.None); | ||
| public static readonly InteropDescriptor System_Contract_CreateStandardAccount = Register("System.Contract.CreateStandardAccount", nameof(CreateStandardAccount), CheckSigPrice, CallFlags.None); |
There was a problem hiding this comment.
My gut feeling is that computationally it's more like CheckSigPrice/2, but that needs to be measured of course.
shargon
left a comment
There was a problem hiding this comment.
Need to be checked if it was used in mainnet. But code looks good
|
I agree with @shargon, changes like this have to be cautious cause it might cause new node fail to synchronize. |
This comment was marked as resolved.
This comment was marked as resolved.
|
We should name every hard fork, to make it more clear which fork we are working on. Not much change to make based on this pr, just add an enum with a list of hardfork names (including names of future harforks) then match them with the hardfork versions would work. |
Good idea. |
There is also a use case for private networks with "whatever is the latest" hard fork enabled, it should be easy to configure that too. |
Done.
Agree. Now you can just delete |
shargon
left a comment
There was a problem hiding this comment.
Code looks good to me, good change!
|
@shargon Can you revert the commit "T4 testnet compatible with 3.2.2"? We can discuss it in a new issue or pr. |
This reverts commit 15bea61.
Fix #2710