Skip to content

Devhawk/getAddressVersion2#2689

Merged
shargon merged 3 commits intoneo-project:developfrom
devhawk:devhawk/getAddressVersion2
Apr 11, 2022
Merged

Devhawk/getAddressVersion2#2689
shargon merged 3 commits intoneo-project:developfrom
devhawk:devhawk/getAddressVersion2

Conversation

@devhawk
Copy link
Contributor

@devhawk devhawk commented Apr 7, 2022 •
edited
Loading

Replacement PR for #2684 that was closed by mistake

@erikzhang
Copy link
Member

erikzhang commented Apr 8, 2022

Since we already have System.Contract.CreateStandardAccount and System.Contract.CreateMultisigAccount, do we need this one anymore? What is the use case?

@devhawk
Copy link
Contributor Author

devhawk commented Apr 8, 2022

UInt

Since we already have System.Contract.CreateStandardAccount and System.Contract.CreateMultisigAccount, do we need this one anymore? What is the use case?

UInt160.ToAddress needs the Address Version.

@erikzhang
Copy link
Member

erikzhang commented Apr 8, 2022

But why do we need to convert script hash to address in a contract? I think it should be done in the frontend.

@devhawk
Copy link
Contributor Author

devhawk commented Apr 8, 2022

But why do we need to convert script hash to address in a contract? I think it should be done in the frontend.

UInt160.ToAddress exists today. I would argue the design is poor since it requires the caller to provide an address version parameter. If there are scenarios for converting a script hash to an address with a different address version than the current chain I can't think of them.

@shargon shargon merged commit 8743a52 into neo-project:develop Apr 11, 2022
@roman-khimov roman-khimov mentioned this pull request Apr 14, 2022
Closed
erikzhang added a commit that referenced this pull request Apr 18, 2022
@erikzhang
3.2.1 (#2694)
ed68274 
* Devhawk/getAddressVersion2 (#2689)

* Fix fee in NativeContract.Invoke (#2692)

* GetTransaction signers (#2685)

* Allow the committee to block a member from the committee (#2695)
ixje added a commit to CityOfZion/dora that referenced this pull request Apr 19, 2022
@ixje
Add GetAddressVersion syscall
02cca91 
neo-project/neo#2689 for neo `3.2.1`
This was referenced Apr 19, 2022
Merged
Merged
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 19, 2022
@ixje
Add GetAddressVersion syscall neo-project/neo#2689
191f841
@ixje ixje mentioned this pull request Apr 19, 2022
Merged
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Apr 19, 2022
@ixje
Add GetAddressVersion syscall neo-project/neo#2689 (#151)
444209b
Thacryba pushed a commit to CityOfZion/dora that referenced this pull request Apr 19, 2022
@ixje
Add GetAddressVersion syscall
2a773dd 
neo-project/neo#2689 for neo `3.2.1`
snowypowers pushed a commit to CityOfZion/neon-js that referenced this pull request Apr 20, 2022
@ixje
feat(sc): Add System.Runtime.GetAddressVersion syscall (#841)
0c39257 
introduced in neo-project/neo#2689 for neo 3.2.1
@devhawk devhawk deleted the devhawk/getAddressVersion2 branch June 8, 2022 23:01
ethan-devspace9ol added a commit to ethan-devspace9ol/neon-js that referenced this pull request Sep 28, 2025
@ethan-devspace9ol
feat(sc): Add System.Runtime.GetAddressVersion syscall (#841)
9e80144 
introduced in neo-project/neo#2689 for neo 3.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devhawk @erikzhang @shargon