Conversation
Member
|
Is not better to change the nep because all the json properties are in lowercase? |
Member
Author
|
|
shargon
previously approved these changes
Apr 27, 2021
Contributor
|
I can't say we're using it often, but we do have a test for it and there is some associated logic. |
Member
|
I will add a UT |
shargon
previously approved these changes
Apr 28, 2021
erikzhang
commented
Apr 29, 2021
vncoelho
reviewed
Apr 29, 2021
Member
vncoelho
left a comment
There was a problem hiding this comment.
I also think this can be removed for now and changed to other name.
Merged
snowypowers
pushed a commit
to CityOfZion/neon-js
that referenced
this pull request
May 19, 2021
The property was initially renamed to isdefault by neo-project/neo#1736 now renamed back to isDefault by neo-project/neo#2451. Close #736
ethan-devspace9ol
added a commit
to ethan-devspace9ol/neon-js
that referenced
this pull request
Sep 28, 2025
The property was initially renamed to isdefault by neo-project/neo#1736 now renamed back to isDefault by neo-project/neo#2451. Close #736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2450