SmartContract: rename hex in ContractParametersContext#2394
Merged
erikzhang merged 3 commits intoneo-project:masterfrom Mar 12, 2021
Merged
SmartContract: rename hex in ContractParametersContext#2394erikzhang merged 3 commits intoneo-project:masterfrom
erikzhang merged 3 commits intoneo-project:masterfrom
Conversation
It's not really hex since neo-project#1199 and even before that it could've been named a bit differently. `item` is not an option because we already have `items` there, but we're signing things so probably it's OK to call this signed thing a `document`.
Seems to be better for this, thanks @shargon.
shargon
approved these changes
Mar 12, 2021
erikzhang
approved these changes
Mar 12, 2021
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not really hex since #1199 and even before that it could've been named a
bit differently.
itemis not an option because we already haveitemsthere, but we're signing things so probably it's OK to call this signed thing
a
document.