Change smart contract hash computation by shargon · Pull Request #2240 · neo-project/neo

shargon · 2021-01-15T10:03:21Z

roman-khimov · 2021-01-15T10:06:21Z

It'll work, but I'm still a little worried about these contracts having the same name. It'd be nice to get az, buki, vedi, etc in the end instead of seven alphabet contracts.

Tommo-L · 2021-01-15T10:17:48Z

src/neo/SmartContract/Native/ContractManagement.cs

        }

+        [ContractMethod(0, CallFlags.WriteStates | CallFlags.AllowNotify)]
+        private ContractState CreateChild(ApplicationEngine engine, StackItem data)


We don't need to create this method, right? We can create a new child contract in contract/script directly, by this following way.

var contract = ContractManagement.GetContract(hash) ContractManagement.Deploy(contract.nef, contract.manifest, data)

The problem is that the sender of the transaction could be the same. Then it will generate the same hash.

https://github.com/neo-project/neo/pull/2240/files#diff-c827c27f2bec36e465fcb3b3af10590d6f952a3888adedc9a7870860ebe72079R146 may fix it.

src/neo/SmartContract/Helper.cs

erikzhang · 2021-01-15T11:28:32Z

Now do we still need CreateChild()? We can use GetContract() to get the manifest, replace the name and then deploy the new contract.

shargon · 2021-01-15T12:11:32Z

Now do we still need CreateChild()? We can use GetContract() to get the manifest, replace the name and then deploy the new contract.

Agree it's a very specific case, and now it can be solved.

roman-khimov · 2021-01-15T12:15:43Z

replace the name

This is the tricky part, because manifest is returned as a JSON string from GetContract().

erikzhang · 2021-01-15T12:43:09Z

This is the tricky part, because manifest is returned as a JSON string from GetContract().

Use System.Json.Serialize and System.Json.Deserialize?

Tommo-L · 2021-01-15T15:19:39Z

replace the name

This is the tricky part, because manifest is returned as a JSON string from GetContract().

Use #2237 to fix it? Create a new deploy method:

deploy(Nef nef, Manifest manifest, StackItem data)

Tommo-L · 2021-01-18T06:07:22Z

Or create a new method, like ContractManagement.Clone/New(ContractState origin, string name) ?

shargon · 2021-01-18T08:51:10Z

Or create a new method, like ContractManagement.Clone/New(ContractState origin, string name) ?

I think that change the name it's easy with the json syscalls

lock9 · 2021-01-19T18:15:01Z

src/neo/SmartContract/Helper.cs

            sb.Emit(OpCode.ABORT);
            sb.EmitPush(sender);
-            sb.EmitPush(script);
+            sb.EmitPush(nefCheckSum);


Shouldn`t the checksum be calculated?

lock9 · 2021-01-19T18:15:30Z

tests/neo.UnitTests/SmartContract/UT_Helper.cs

-            Assert.AreEqual("0xb8e95ff7b11c427c29355e3398722d97bd2ca069", Neo.SmartContract.Helper.GetContractHash(UInt160.Zero, nef.Script).ToString());
-            Assert.AreEqual("0x435c467b8e15cb9b1474ad7ee817ffdcfededef9", Neo.SmartContract.Helper.GetContractHash(UInt160.Parse("0xa400ff00ff00ff00ff00ff00ff00ff00ff00ff01"), nef.Script).ToString());
+            Assert.AreEqual("0x9b9628e4f1611af90e761eea8cc21372380c74b6", Neo.SmartContract.Helper.GetContractHash(UInt160.Zero, nef.CheckSum, "").ToString());
+            Assert.AreEqual("0x66eec404d86b918d084e62a29ac9990e3b6f4286", Neo.SmartContract.Helper.GetContractHash(UInt160.Parse("0xa400ff00ff00ff00ff00ff00ff00ff00ff00ff01"), nef.CheckSum, "").ToString());


Why are they called "" instead of Neo and Gas?

It allows to deploy the same NEF using one sender and get different contract hashes. See neo-project/neo#2240.

* CreateChild * Change to checkSum * Remove nonce * Change manifest to name * Remove new method * Clean changes

CreateChild

65203c3

shargon requested a review from erikzhang January 15, 2021 10:03

Tommo-L reviewed Jan 15, 2021

View reviewed changes

erikzhang reviewed Jan 15, 2021

View reviewed changes

src/neo/SmartContract/Helper.cs Outdated Show resolved Hide resolved

shargon added 2 commits January 15, 2021 12:06

Change to checkSum

7bc110e

Remove nonce

d654424

erikzhang reviewed Jan 15, 2021

View reviewed changes

src/neo/SmartContract/Helper.cs Outdated Show resolved Hide resolved

Change manifest to name

85075f7

shargon added 2 commits January 15, 2021 13:09

Remove new method

8170c55

Clean changes

fd8c102

shargon changed the title ~~CreateChild~~ Change smart contract hash computation Jan 15, 2021

shargon added the Backward-Incompatible label Jan 15, 2021

superboyiii mentioned this pull request Jan 18, 2021

Preview5 Checklist #2171

Closed

36 tasks

Merge branch 'master' into create-child

c319e43

shargon requested review from Tommo-L and erikzhang January 18, 2021 09:06

Ashuaidehao mentioned this pull request Jan 19, 2021

Change smart contract hash computation neo-project/neo-devpack-dotnet#438

Merged

erikzhang approved these changes Jan 19, 2021

View reviewed changes

shargon added 2 commits January 19, 2021 10:43

Merge branch 'master' into create-child

3e11e4b

Merge branch 'master' into create-child

fb150af

shargon merged commit 5f17eee into neo-project:master Jan 19, 2021

shargon deleted the create-child branch January 19, 2021 09:45

lock9 reviewed Jan 19, 2021

View reviewed changes

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Jan 22, 2021

state: use checksums and names to calculate contract hashes

054ca27

It allows to deploy the same NEF using one sender and get different contract hashes. See neo-project/neo#2240.

roman-khimov mentioned this pull request Jan 22, 2021

Update contract hash calculation scheme nspcc-dev/neo-go#1686

Merged

cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021

Change smart contract hash computation (neo-project#2240)

607ef25

* CreateChild * Change to checkSum * Remove nonce * Change manifest to name * Remove new method * Clean changes

ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 16, 2021

https://github.com/neo-project/neo/pull/2240

023b986

csmuller mentioned this pull request Aug 12, 2021

Calling StdLib.JsonSerialize on a contract manifest returns error "Specified cast is not valid." #2571

Closed

Conversation

shargon commented Jan 15, 2021

Uh oh!

roman-khimov commented Jan 15, 2021

Uh oh!

Tommo-L Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

erikzhang Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tommo-L Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erikzhang commented Jan 15, 2021

Uh oh!

shargon commented Jan 15, 2021

Uh oh!

roman-khimov commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Jan 15, 2021

Uh oh!

Tommo-L commented Jan 15, 2021

Uh oh!

Tommo-L commented Jan 18, 2021

Uh oh!

shargon commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lock9 Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

lock9 Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erikzhang Jan 15, 2021 •

edited

Loading

roman-khimov commented Jan 15, 2021 •

edited

Loading

shargon commented Jan 18, 2021 •

edited

Loading