Conversation
|
Can someone fix the UT? I can't mock the consensus nodes in |
vncoelho
left a comment
There was a problem hiding this comment.
I need to understand this concept of ExtensiblePayload.
I can try to fix, but may need some couple of days @erikzhang,3-5.
If someone can fix before it I can double check.
There was a problem hiding this comment.
As far as I could investigate, @erikzhang, there is a problem with the RecoveryMessage.
Basically, I commented all tests...aehauheaue
But kept ConsensusService_SingleNodeActors_OnStart_PrepReq_PrepResponses_Commits, which checks a lot of things about the consensus flow.
There is something going on that CommitPayload is not being recovered.
|
I am sending the commit here and will keep uncommenting as soon as we advance. |
Console.WriteLine($"\nHI INSIDE RECOVERY IF ...{commitPayloads.Length}");
totalCommits = commitPayloads.Length;
foreach (ExtensiblePayload commitPayload in commitPayloads)
if (ReverifyAndProcessPayload(commitPayload)) validCommits++;
Console.WriteLine($"\nVALID COMMITS ...{validCommits}");
HI INSIDE RECOVERY IF ...4
VALID COMMITS ...0Something is happening on line |
|
The problem is that the mocked validators are not in the whitelist. |
I will try to add them with reflection |
|
UT Fixed, we should create the module before merge it in order to test it well |
We can test it without creating module. |
|
@neo-project/ngd-shanghai Test? |
|
I will start to create the module after merging this. |
shargon
left a comment
There was a problem hiding this comment.
It's good for me, we can test it later
but we keep the existing Consensus payloads instead of deleting.
No description provided.