Skip to content

Reduce deploy fee#2153

Merged
erikzhang merged 5 commits intoneo-project:masterfrom
Tommo-L:fix_deploy_fee
Dec 17, 2020
Merged

Reduce deploy fee#2153
erikzhang merged 5 commits intoneo-project:masterfrom
Tommo-L:fix_deploy_fee

Conversation

@Tommo-L
Copy link
Contributor

@Tommo-L Tommo-L commented Dec 16, 2020 •
edited
Loading

Close #2151

Some discussion
#2140 (comment)
#2001

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Dec 16, 2020

In the future, we can raise it appropriately, and the threshold should be lowered in the early stage.

erikzhang
erikzhang reviewed Dec 16, 2020
View reviewed changes
erikzhang
erikzhang approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for other developers' comments. @neo-project/core @neo-project/ngd-seattle @neo-project/ngd-shanghai @roman-khimov

@devhawk
Copy link
Contributor

devhawk commented Dec 16, 2020

In the future, we can raise it appropriately, and the threshold should be lowered in the early stage.

Should it be configurable? (in the future, not for preview 4)

@superboyiii
Copy link
Member

superboyiii commented Dec 16, 2020 •
edited
Loading

I agree with this.

Should it be configurable? (in the future, not for preview 4)

Yes, it should be configurable, after preview4.

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Dec 16, 2020

Should it be configurable? (in the future, not for preview 4)

@devhawk @superboyiii It's already configurable.

neo/src/neo/SmartContract/Native/ManagementContract.cs

Lines 60 to 66 in 06d4345

[ContractMethod(0_03000000, CallFlags.WriteStates)]
private void SetMinimumDeploymentFee(ApplicationEngine engine, BigInteger value)
{
if (value < 0) throw new ArgumentOutOfRangeException(nameof(value));
if (!CheckCommittee(engine)) throw new InvalidOperationException();
engine.Snapshot.Storages.GetAndChange(CreateStorageKey(Prefix_MinimumDeploymentFee)).Set(value);
}

@superboyiii
Copy link
Member

superboyiii commented Dec 16, 2020

Prefix_MinimumDeploymentFee

Got it.

roman-khimov
roman-khimov approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 is good for me.

steven1227
steven1227 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@steven1227 steven1227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support on it.

@superboyiii
Copy link
Member

superboyiii commented Dec 16, 2020

Merge?

@superboyiii
Copy link
Member

superboyiii commented Dec 16, 2020

We could wait for a bit more hours for others. If no disagreement, I think it could be merged.

@AnnaShaleva AnnaShaleva mentioned this pull request Dec 16, 2020
Merged
2 tasks
@erikzhang erikzhang merged commit 6add2eb into neo-project:master Dec 17, 2020
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@Tommo-L
Reduce deploy fee (neo-project#2153)
3bde341
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@Tommo-L @cloud8little
Reduce deploy fee (neo-project#2153)
2dc1752
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
@ixje
https://github.com/neo-project/neo/pull/2153
6db98ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

@vncoelho vncoelho vncoelho approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

+2 more reviewers

@steven1227 steven1227 steven1227 approved these changes

@superboyiii superboyiii superboyiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestModeGas no longer big enough for contract deployment

8 participants

@Tommo-L @devhawk @superboyiii @shargon @steven1227 @erikzhang @vncoelho @roman-khimov