fix blockchain on transaction array logic#2146
Merged
erikzhang merged 7 commits intoneo-project:masterfrom Dec 16, 2020
Merged
Conversation
shargon
previously approved these changes
Dec 14, 2020
Member
|
neo/src/neo/Ledger/MemoryPool.cs Lines 109 to 118 in eb63d30 I think there is no need to return And also we don't need to send the transactions from |
Contributor
Author
If there are more transactions in mempool than MaxTransactionPerBlock I think this logic will be executed? |
Member
|
Let's remove |
Contributor
Author
|
@erikzhang Please have a look |
erikzhang
approved these changes
Dec 16, 2020
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2116 (comment)