Conversation
Member
Author
Contributor
|
CODING MACHINE |
Contributor
|
The code looks good, but I think some UT is recommended. Thanks a lot for the super speed Erik! |
lock9
reviewed
Dec 11, 2020
| return sb.Emit(OpCode.PACK); | ||
| } | ||
|
|
||
| public static ScriptBuilder CreateMap<TKey, TValue>(this ScriptBuilder sb, IReadOnlyDictionary<TKey, TValue> map = null) |
Contributor
There was a problem hiding this comment.
Shouldn't we keep the naming "Emit" or "Push"?
Member
Author
There was a problem hiding this comment.
Because it does not directly push the map, it actually creates a new map.
shargon
approved these changes
Dec 12, 2020
Contributor
|
Hello @shargon and @erikzhang , if we don't add these instructions to the EmitPush method, we create a situation where you can use the EmitPush method, but it will fail with an exception. In a few words: it compiles but fails in runtime:
|
Member
|
@lock9 but |
45 tasks
12 tasks
This was referenced Jan 7, 2021
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2143