Skip to content

Fix CallNative#2144

Merged
erikzhang merged 2 commits intomasterfrom
fixes/native-flag
Dec 12, 2020
Merged

Fix CallNative#2144
erikzhang merged 2 commits intomasterfrom
fixes/native-flag

Conversation

@erikzhang
Copy link
Member

@erikzhang erikzhang commented Dec 11, 2020

Fix #2142

@erikzhang
Copy link
Member Author

erikzhang commented Dec 11, 2020

@AnnaShaleva

@roman-khimov
Copy link
Contributor

roman-khimov commented Dec 11, 2020

Don't we actually want to make flags CallFlags.ReadStates | CallFlags.AllowCall in VerifyWitness? Contracts can do calls to other contracts in their verification methods. And security-wise disabling calls (unsetting AllowCall) should disable calls to native contracts too, so we better have AllowCall in System_Contract_CallNative descriptor.

@erikzhang
Copy link
Member Author

erikzhang commented Dec 12, 2020

And security-wise disabling calls (unsetting AllowCall) should disable calls to native contracts too

Calls to native contracts need to execute System.Contract.Call, which requires AllowCall flag.

@erikzhang erikzhang merged commit eb63d30 into master Dec 12, 2020
@erikzhang erikzhang deleted the fixes/native-flag branch December 12, 2020 12:17
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 13, 2020
@roman-khimov
core: don't allow calls in verification context
eeb57ce 
Follow neo-project/neo#2144. System.Contract.CallNative already has "None"
flag, so tests work fine.
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020
@roman-khimov
core: don't allow calls in verification context
fc10f4e 
Follow neo-project/neo#2144. System.Contract.CallNative already has "None"
flag, so tests work fine.
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020
@roman-khimov
core: don't allow calls in verification context
d42d330 
Follow neo-project/neo#2144. System.Contract.CallNative already has "None"
flag, so tests work fine.
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Dec 14, 2020
@roman-khimov
core: don't allow calls in verification context
938be29 
Follow neo-project/neo#2144. System.Contract.CallNative already has "None"
flag, so tests work fine.
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@erikzhang
Fix CallNative (neo-project#2144)
5814902
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @cloud8little
Fix CallNative (neo-project#2144)
5321c8b
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
@ixje
https://github.com/neo-project/neo/pull/2144
a6afe9e
@roman-khimov roman-khimov mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add AllowCall call flag to VerifyWitness for native contracts

3 participants

@erikzhang @roman-khimov @shargon