Skip to content

Call from native contract synchronously#2130

Merged
shargon merged 3 commits intomasterfrom
sync-callfromnative
Dec 9, 2020
Merged

Call from native contract synchronously#2130
shargon merged 3 commits intomasterfrom
sync-callfromnative

Conversation

@erikzhang
Copy link
Member

No description provided.

shargon
shargon previously approved these changes Dec 9, 2020
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could @superboyiii test it with neo-project/neo-devpack-dotnet#391 ?

@cloud8little
Copy link
Contributor

It does not work. :( Callingscripthash is still the contract hash.
2d8c1980809da636db510512a632a10

@shargon
Copy link
Member

shargon commented Dec 9, 2020

@cloud8little please try it again

@cloud8little
Copy link
Contributor

@cloud8little please try it again

The commit 4a5a822 works. Mint with neo/gas multiple times successful.

beba8a833bcdd8200a23b386ae6730a

@erikzhang
Copy link
Member Author

Merge?

@shargon shargon merged commit e55c356 into master Dec 9, 2020
@shargon shargon deleted the sync-callfromnative branch December 9, 2020 10:55
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
* Call from native contract synchronously

* Use native callingScriptHash

* Optimize

Co-authored-by: Shargon <shargon@gmail.com>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
* Call from native contract synchronously

* Use native callingScriptHash

* Optimize

Co-authored-by: Shargon <shargon@gmail.com>
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants