Merged
Conversation
Member
|
Maybe we can move {
"name": "symbol",
"parameters": [],
"returntype": "String",
"offset": 0,
"safe": true
} |
Member
Author
I will do that |
Member
|
Native contracts' abi should be updated too. |
Member
|
@neo-project/ngd-shanghai Can you test it? |
Member
Author
|
@neo-project/ngd-shanghai you can use neo-project/neo-devpack-dotnet#401 |
Tommo-L
reviewed
Dec 7, 2020
| throw new InvalidOperationException($"Cannot Call Method {method} Of Contract {contractHash} From Contract {CurrentScriptHash}"); | ||
| if (md.Safe) | ||
| { | ||
| flags &= ~CallFlags.AllowModifyStates; |
Contributor
There was a problem hiding this comment.
If a method is marked as Safe, will it not be allowed to modify states?
Contributor
|
What about having |
Member
Author
I think developers should know more about the core to use this properly, it is easier for adoption to make things easier. |
erikzhang
previously approved these changes
Dec 8, 2020
erikzhang
previously approved these changes
Dec 8, 2020
erikzhang
approved these changes
Dec 9, 2020
45 tasks
7 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* Check safemethod * Move safe method to Abi * Native safe * Fix merge Co-authored-by: Erik Zhang <erik@neo.org>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Check safemethod * Move safe method to Abi * Native safe * Fix merge Co-authored-by: Erik Zhang <erik@neo.org>
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2117