Skip to content

Make KeyBuilder public so neo-debugger can use it#2099

Merged
shargon merged 5 commits intoneo-project:masterfrom
devhawk:patch-6
Nov 25, 2020
Merged

Make KeyBuilder public so neo-debugger can use it#2099
shargon merged 5 commits intoneo-project:masterfrom
devhawk:patch-6

Conversation

@devhawk
Copy link
Contributor

@devhawk devhawk commented Nov 24, 2020

No description provided.

Tommo-L
Tommo-L previously approved these changes Nov 25, 2020
shargon
shargon previously approved these changes Nov 25, 2020
@erikzhang
Copy link
Member

The KeyBuilder class is used in native contracts only. If it will be used in other places, I think it should be moved to other namespace instead of Neo.SmartContract.Native.

@shargon shargon dismissed stale reviews from Tommo-L and themself via f44ea17 November 25, 2020 10:34
@shargon shargon merged commit 8979c40 into neo-project:master Nov 25, 2020
AnnaShaleva pushed a commit to AnnaShaleva/neo that referenced this pull request Nov 26, 2020
* Make KeyBuilder public so neo-debugger can use it

* Move namespace

* Clean using

Co-authored-by: Shargon <shargon@gmail.com>
@devhawk devhawk deleted the patch-6 branch December 9, 2020 17:54
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
* Make KeyBuilder public so neo-debugger can use it

* Move namespace

* Clean using

Co-authored-by: Shargon <shargon@gmail.com>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
* Make KeyBuilder public so neo-debugger can use it

* Move namespace

* Clean using

Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants