Are we expecting to merge this before preview 4?

Merge?

Are we expecting to merge this before preview 4?

I think that it's good, we can test it more. What do you think?

@neo-project/ngd-shanghai

Are we expecting to merge this before preview 4?

I think that it's good, we can test it more. What do you think?

If you're asking me @shargon, I think we should get preview 4 out the door first.

under test

@neo-project/ngd-shanghai

I think it should be merged after Preview4 so that we could make more test on .NET5.0

When Microsoft.EntityFrameworkCore.Sqlite and Microsoft.Extensions.Configuration.Json are both version "3.1.3", smoke test passed.

When Microsoft.EntityFrameworkCore.Sqlite or Microsoft.Extensions.Configuration.Json is version "5.0.0", Rpc call failed here:
https://github.com/neo-project/neo-modules/blob/master/src/RpcServer/RpcServer.cs#L199

When Microsoft.EntityFrameworkCore.Sqlite and Microsoft.Extensions.Configuration.Json are both version "3.1.3", smoke test passed.

When Microsoft.EntityFrameworkCore.Sqlite or Microsoft.Extensions.Configuration.Json is version "5.0.0", Rpc call failed here:
https://github.com/neo-project/neo-modules/blob/master/src/RpcServer/RpcServer.cs#L199

neo-project/neo-modules#407

https://github.com/neo-project/neo/blob/master/.github/workflows/main.yml#L24-L25

Maybe it should be updated to

dotnet tool install --version 5.0.142902 --tool-path ./ dotnet-format --add-source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json
./dotnet-format . --check -v diagnostic

Reference

@erikzhang more detailed information, if it is a must to upgrade these two dependencies, it is better to solve this problem.

Exception Stack Info:

System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=Microsoft.AspNetCore.Server.Kestrel.Core
  StackTrace:
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.CreateResponseHeader(Boolean appCompleted)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProduceStart(Boolean appCompleted)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.InitializeResponseAsync(Int32 firstWriteByteCount)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.WriteAsync(ReadOnlyMemory`1 data, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpResponseStream.WriteAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Http.HttpResponseWritingExtensions.WriteAsync(HttpResponse response, String text, Encoding encoding, CancellationToken cancellationToken)
   at Neo.Plugins.RpcServer.<ProcessAsync>d__22.MoveNext() in D:\Github\workflow\neo-modules\src\RpcServer\RpcServer.cs:line 199

When Microsoft.EntityFrameworkCore.Sqlite and Microsoft.Extensions.Configuration.Json are both version "3.1.3", smoke test passed.
When Microsoft.EntityFrameworkCore.Sqlite or Microsoft.Extensions.Configuration.Json is version "5.0.0", Rpc call failed here:
https://github.com/neo-project/neo-modules/blob/master/src/RpcServer/RpcServer.cs#L199

neo-project/neo-modules#407

No, it is not.

Now it can be merged.

Now it can be merged.

@erikzhang are we waiting until after preview 4?

Preview4 nuget package has been released.