Reuse BinarySerializer for checking notifications#2071
Merged
Conversation
Member
Author
roman-khimov
approved these changes
Nov 18, 2020
Contributor
roman-khimov
left a comment
There was a problem hiding this comment.
We can catch NotSupportedException and throw ArgumentException (that was thrown previously for check failure), though maybe it's not worth complicating the code, the end result is similar.
shargon
approved these changes
Nov 18, 2020
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2069