Skip to content

Optimize NextConsensus#2015

Merged
erikzhang merged 4 commits intoneo-project:masterfrom
Qiao-Jin:optimize_nextconsensus
Oct 27, 2020
Merged

Optimize NextConsensus#2015
erikzhang merged 4 commits intoneo-project:masterfrom
Qiao-Jin:optimize_nextconsensus

Conversation

@Qiao-Jin
Copy link
Contributor

@Qiao-Jin Qiao-Jin commented Oct 23, 2020

Close #2014

@cloud8little
Copy link
Contributor

Test passed with #1848 . In block 10, voter vote to a new account with 2000,0000 votes, the validator update for consensus in block 13.
779da6ca270c0be95528ddf86952d56

and open the new account start consensus success.

shargon
shargon previously approved these changes Oct 23, 2020
@erikzhang
Copy link
Member

Where is it used?

@Tommo-L
Copy link
Contributor

Tommo-L commented Oct 26, 2020

Where is it used?

The value of NextConseus is incorrent.

NextConsensus = Blockchain.GetConsensusAddress(NativeContract.NEO.ComputeNextBlockValidators(Snapshot))

@erikzhang
Copy link
Member

Can you move this logic to ConsensusContext? Or just use GetNextBlockValidators().

@Qiao-Jin
Copy link
Contributor Author

Can you move this logic to ConsensusContext? Or just use GetNextBlockValidators().

Have moved logic to ConsensusContext

@erikzhang
Copy link
Member

Tested?

@cloud8little
Copy link
Contributor

Testing

@cloud8little
Copy link
Contributor

Testing

Test Passed. Good to merge.

@erikzhang erikzhang merged commit 7a58426 into neo-project:master Oct 27, 2020
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consensus fail after updating validators

5 participants