Skip to content

Add role designation history#2007

Merged
shargon merged 28 commits intoneo-project:masterfrom
ZhangTao1596:fix-role-designate-history
Nov 3, 2020
Merged

Add role designation history#2007
shargon merged 28 commits intoneo-project:masterfrom
ZhangTao1596:fix-role-designate-history

Conversation

@ZhangTao1596
Copy link

@ZhangTao1596 ZhangTao1596 commented Oct 15, 2020 •
edited
Loading

I make this pr to let DesignateContract record historical role designation. So users can verify old messages.
Changes:

  • DesignateContract add height and nodes when call DesignateAsRole
  • Add GetDesignatedByRoleAndIndex to return designated nodes at specific index

@erikzhang @shargon @Tommo-L Please have a look.

@ZhangTao1596 ZhangTao1596 changed the title Fix role designate history Add role designation history Oct 15, 2020
@shargon
Copy link
Member

shargon commented Oct 15, 2020

Why do you want to verify old messages in the present, if they was verified already in the past?

@ZhangTao1596
Copy link
Author

ZhangTao1596 commented Oct 15, 2020 •
edited
Loading

Why do you want to verify old messages in the present, if they was verified already in the past?

Not all messages signed by designated nodes saved in block, so these messages will not be sync with blockchain snapshot.
Take StateRoot for example, a node may receive StateRoot with index 100 when it already have sync block at 1000, It can't verify StateRoot with current snapshot. Designated nodes may change.

@shargon
Copy link
Member

shargon commented Oct 15, 2020

Wait for #1988 we need to store the history in different keys.

@roman-khimov
Copy link
Contributor

roman-khimov commented Oct 16, 2020

Take StateRoot for example, a node may receive StateRoot with index 100 when it already have sync block at 1000, It can't verify StateRoot with current snapshot. Designated nodes may change.

Hmm... What if we're to include state root hash in the block header?

@ZhangTao1596
Copy link
Author

ZhangTao1596 commented Oct 19, 2020

Hmm... What if we're to include state root hash in the block header?

Only considering state root, if we put it into header, we do not need this.

shargon
shargon reviewed Oct 19, 2020
View reviewed changes
@ProDog
Copy link
Contributor

ProDog commented Oct 19, 2020

If there are two designate transactions in one block, can only get the last one?

shargon
shargon reviewed Oct 19, 2020
View reviewed changes
@ZhangTao1596
Copy link
Author

ZhangTao1596 commented Oct 19, 2020

If there are two designate transactions in one block, can only get the last one?

What do you mean the last one?

@ProDog
Copy link
Contributor

ProDog commented Oct 19, 2020

What do you mean the last one?

The last transaction's history.

@ZhangTao1596
Copy link
Author

ZhangTao1596 commented Oct 20, 2020

What do you mean the last one?

The last transaction's history.

Yes. Because designate transaction decide who are the nodes as specific role of next block. The last designate tx in same block will cover the previous.

@ProDog
Copy link
Contributor

ProDog commented Oct 20, 2020

Tested OK.

neo> designate [{"type":"Integer","value":8},{"type":"Array","value":[{"type":"PublicKey","value":"02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b"},{"type":"PublicKey","value":"028bd1902c4d1419f002b821e6de653ddfd5358063208e426756398be6ffa3aac8"},{"type":"PublicKey","value":"0222d8515184c7d62ffa99b829aeb4938c4704ecb0dd7e340e842e9df121826343"},{"type":"PublicKey","value":"02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b"},{"type":"PublicKey","value":"02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b"}]}] 0xe19de267a37a71734478f512b3e92c79fc3695fa 0xe19de267a37a71734478f512b3e92c79fc3695fa
Invoking script with: 'DCECqepoQswMs7DyMXsHyFDePR4rJDqY7S1Wo/9MpmqvMwsMIQKp6mhCzAyzsPIxewfIUN49HiskOpjtLVaj/0ymaq8zCwwhAiLYUVGEx9Yv+pm4Ka60k4xHBOyw3X40DoQunfEhgmNDDCECi9GQLE0UGfACuCHm3mU939U1gGMgjkJnVjmL5v+jqsgMIQKp6mhCzAyzsPIxewfIUN49HiskOpjtLVaj/0ymaq8zCxXAGBLADA9kZXNpZ25hdGVBc1JvbGUMFGYmxmjw6Aa+yKJodaaguz7P/jp2QWJ9W1I='
VM State: HALT
Gas Consumed: 0.0101553
Result Stack: [{"type":"Boolean","value":true}]
Relay tx(no|yes): yes
Signed and relayed transaction with hash=0xc49bfc15ae51158ce758d334b6b844d5de976a4098e4994d34a1e84a227951e5

neo> designate [{"type":"Integer","value":8},{"type":"Array","value":[{"type":"PublicKey","value":"02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b"}]}] 0xe19de267a37a71734478f512b3e92c79fc3695fa 0xe19de267a37a71734478f512b3e92c79fc3695fa
Invoking script with: 'DCECqepoQswMs7DyMXsHyFDePR4rJDqY7S1Wo/9MpmqvMwsRwBgSwAwPZGVzaWduYXRlQXNSb2xlDBRmJsZo8OgGvsiiaHWmoLs+z/46dkFifVtS'
VM State: HALT
Gas Consumed: 0.0101481
Result Stack: [{"type":"Boolean","value":true}]
Relay tx(no|yes): yes
Signed and relayed transaction with hash=0x2ff1b554b3412db1e80a06a02005d393dfc366be622861837925ee4f30b0f69a

neo> get designated by index 8 86
Invoking script with: 'AFYYEsAMG2dldERlc2lnbmF0ZWRCeVJvbGVBbmRJbmRleAwUZibGaPDoBr7Iomh1pqC7Ps/+OnZBYn1bUg=='
VM State: HALT
Gas Consumed: 0.0200763
Designated:
02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b
028bd1902c4d1419f002b821e6de653ddfd5358063208e426756398be6ffa3aac8
0222d8515184c7d62ffa99b829aeb4938c4704ecb0dd7e340e842e9df121826343
02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b
02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b

neo> designate [{"type":"Integer","value":8},{"type":"Array","value":[{"type":"PublicKey","value":"0222d8515184c7d62ffa99b829aeb4938c4704ecb0dd7e340e842e9df121826343"}]}] 0xe19de267a37a71734478f512b3e92c79fc3695fa 0xe19de267a37a71734478f512b3e92c79fc3695fa
Invoking script with: 'DCECIthRUYTH1i/6mbgprrSTjEcE7LDdfjQOhC6d8SGCY0MRwBgSwAwPZGVzaWduYXRlQXNSb2xlDBRmJsZo8OgGvsiiaHWmoLs+z/46dkFifVtS'
VM State: HALT
Gas Consumed: 0.0101481
Result Stack: [{"type":"Boolean","value":true}]
Relay tx(no|yes): yes
Signed and relayed transaction with hash=0x2ffc8aeafcdc0b55f3c1964737249742304536a3087ca2292df067cefe94ae24

neo> designate [{"type":"Integer","value":8},{"type":"Array","value":[{"type":"PublicKey","value":"02a9ea6842cc0cb3b0f2317b07c850de3d1e2b243a98ed2d56a3ff4ca66aaf330b"}]}] 0xe19de267a37a71734478f512b3e92c79fc3695fa 0xe19de267a37a71734478f512b3e92c79fc3695fa
Invoking script with: 'DCECqepoQswMs7DyMXsHyFDePR4rJDqY7S1Wo/9MpmqvMwsRwBgSwAwPZGVzaWduYXRlQXNSb2xlDBRmJsZo8OgGvsiiaHWmoLs+z/46dkFifVtS'
VM State: HALT
Gas Consumed: 0.0101481
Result Stack: [{"type":"Boolean","value":true}]
Relay tx(no|yes): yes
Signed and relayed transaction with hash=0x828b8c62600221acce344554d2c1f95dd448e246e25e4c19cabbea85801d8ccd

neo> get designated by index 8 94
Invoking script with: 'AF4YEsAMG2dldERlc2lnbmF0ZWRCeVJvbGVBbmRJbmRleAwUZibGaPDoBr7Iomh1pqC7Ps/+OnZBYn1bUg=='
VM State: HALT
Gas Consumed: 0.0200763
Designated:
0222d8515184c7d62ffa99b829aeb4938c4704ecb0dd7e340e842e9df121826343

shargon
shargon reviewed Oct 20, 2020
View reviewed changes
shargon
shargon reviewed Oct 21, 2020
View reviewed changes
shargon
shargon reviewed Oct 21, 2020
View reviewed changes
shargon
shargon previously approved these changes Oct 27, 2020
View reviewed changes
shargon
shargon previously approved these changes Nov 1, 2020
View reviewed changes
erikzhang
erikzhang reviewed Nov 2, 2020
View reviewed changes
shargon
shargon previously approved these changes Nov 2, 2020
View reviewed changes
erikzhang
erikzhang requested changes Nov 2, 2020
View reviewed changes
@chenzhitong chenzhitong mentioned this pull request Nov 3, 2020
Merged
@shargon shargon merged commit 1d4db2c into neo-project:master Nov 3, 2020
@ZhangTao1596 ZhangTao1596 deleted the fix-role-designate-history branch November 4, 2020 01:46
@cloud8little cloud8little mentioned this pull request Nov 4, 2020
Merged
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 5, 2020
@roman-khimov
native: implement designate contract history retention
b88c7bd 
Follow neo-project/neo#2007. Fix getDesignatedByRole price along the way.
@roman-khimov roman-khimov mentioned this pull request Nov 5, 2020
Merged
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 6, 2020
@roman-khimov
native: implement designate contract history retention
9e781bf 
Follow neo-project/neo#2007. Fix getDesignatedByRole price along the way.
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
17 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@Tommo-L @shargon @erikzhang
Add role designation history (neo-project#2007)
8d1c8b5 
* record historical designation

* fix ut

* sort

* Remove sort

* use different key

* fix some

* Store it as BiEndian

* avoid in same block

* Optimize

* use findrange

* optimize index get

* Erik's feedback

* Fix UT

* fix empty sequence

* optimize height

* fix ut

* index

* fix ut

Co-authored-by: Luchuan <luchuan@ngd.neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@Tommo-L @shargon
@erikzhang @cloud8little
Add role designation history (neo-project#2007)
b021100 
* record historical designation

* fix ut

* sort

* Remove sort

* use different key

* fix some

* Store it as BiEndian

* avoid in same block

* Optimize

* use findrange

* optimize index get

* Erik's feedback

* Fix UT

* fix empty sequence

* optimize height

* fix ut

* index

* fix ut

Co-authored-by: Luchuan <luchuan@ngd.neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021
@ixje
https://github.com/neo-project/neo/pull/2007
58b69c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

+1 more reviewer

@Tommo-L Tommo-L Tommo-L left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZhangTao1596 @shargon @roman-khimov @ProDog @erikzhang @Tommo-L