Merged
Conversation
added 3 commits
September 22, 2020 17:31
vncoelho
reviewed
Sep 22, 2020
Member
vncoelho
left a comment
There was a problem hiding this comment.
Looks a good design for designating roles on the blockchain, such as the idea of running stateroots on other nodes.
Perhaps this is a good generic change even if we keep stateroort on CN.
shargon
reviewed
Sep 22, 2020
Member
|
I like the idea, it's more extensible. |
erikzhang
reviewed
Sep 23, 2020
erikzhang
approved these changes
Sep 23, 2020
shargon
approved these changes
Sep 23, 2020
45 tasks
17 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* add designate contract * format * fix * Some checks * reorganize file * Remove empty line * Update DesignateContract.cs * ArgumentOutOfRangeException * Update DesignateContract.cs * Remove OracleContract.Lists.cs Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: erikzhang <erik@neo.org>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* add designate contract * format * fix * Some checks * reorganize file * Remove empty line * Update DesignateContract.cs * ArgumentOutOfRangeException * Update DesignateContract.cs * Remove OracleContract.Lists.cs Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: erikzhang <erik@neo.org>
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add designate contract so that we can add more roles in the future.
DesignateContractOracleContracttoDesignateContractStateValidatornode list@erikzhang @shargon @Tommo-L