Optimize multiple ECPoint encoding#1939
Merged
shargon merged 11 commits intoneo-project:masterfrom Sep 18, 2020
Merged
Conversation
This reverts commit 5866669.
vncoelho
reviewed
Sep 16, 2020
Member
vncoelho
left a comment
There was a problem hiding this comment.
Looks good, Shargon. I agree it may be good to cache this converstion.
vncoelho
reviewed
Sep 16, 2020
src/neo/Cryptography/ECC/ECPoint.cs
Outdated
| } | ||
|
|
||
| public byte[] EncodePoint(bool commpressed) | ||
| public byte[] EncodePoint(bool commpressed, bool allowCache = true) |
Member
There was a problem hiding this comment.
What is the purpose of allowCache? Is there any benefit in some uses?
Member
Author
There was a problem hiding this comment.
I want to avoid the modification of this array inside the VM, but I changed the logic
erikzhang
reviewed
Sep 17, 2020
erikzhang
approved these changes
Sep 17, 2020
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* Optimize multiple encodes * Fix hashcode * Revert "Fix hashcode" This reverts commit 5866669. * Test cache * Fix UT * Fix Smart contract cache * Fix set without cache * Improve * Remove allowCache * fix english * Remove change
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Optimize multiple encodes * Fix hashcode * Revert "Fix hashcode" This reverts commit 5866669. * Test cache * Fix UT * Fix Smart contract cache * Fix set without cache * Improve * Remove allowCache * fix english * Remove change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1321