add magic parameter overloads to GetHashData and Sign#1902
Merged
erikzhang merged 4 commits intoneo-project:masterfrom Sep 6, 2020
devhawk:devhawk/fix-magic
Merged
add magic parameter overloads to GetHashData and Sign#1902erikzhang merged 4 commits intoneo-project:masterfrom devhawk:devhawk/fix-magic
erikzhang merged 4 commits intoneo-project:masterfrom
devhawk:devhawk/fix-magic
Conversation
Member
|
But |
shargon
previously approved these changes
Sep 3, 2020
Member
By default it will work as before |
Contributor
Author
Yes. it's designed that way on purpose. |
Contributor
Author
|
|
Contributor
Author
|
I added a CalculateHash helper extension method to match GetHashData and Sign. |
shargon
reviewed
Sep 3, 2020
shargon
approved these changes
Sep 3, 2020
erikzhang
approved these changes
Sep 6, 2020
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1900
Once this is merged, will need to add an overload to RpcClient TransactionManager.Sign[Async] that takes an explicit Magic uint parameter and calls the explicit magic overload of IVerifiable.Sign extension method (which calls explicit magic overload of IVerifiable.GetHashData)