Merged
Conversation
Member
|
|
Member
Author
|
Yes, it's better, but the consensus UT use -1, we can fix the UT and change to uint |
Member
Author
|
The problem is that ConsensusService use Blockchain.Singleton and it has 1 Height. So it can't meet this UT neo/tests/neo.UnitTests/Consensus/UT_Consensus.cs Lines 169 to 180 in ca13358 |
Member
Author
|
I think that now it's better, because if |
erikzhang
previously approved these changes
Aug 13, 2020
Member
|
Test need to be fixed. |
erikzhang
approved these changes
Aug 13, 2020
45 tasks
2 tasks
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Fix 1834 * Fix UT * Remove useless condition Co-authored-by: Erik Zhang <erik@neo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to ensure that all the indexes can fit in LastSeenMessage, if we use a integer type, we have the half available chain.
Also, if heigh it's 0,
LastSeenMessage?.Count(p => Block.Index > 0 && p.Value < (Block.Index - 1)) ?? 0;it will produce an integer overflow, and the condition always will be true.