Implement Base58 Encode and Decode Interops on Neo#1833
Merged
shargon merged 4 commits intoneo-project:masterfrom Aug 14, 2020
Merged
Implement Base58 Encode and Decode Interops on Neo#1833shargon merged 4 commits intoneo-project:masterfrom
shargon merged 4 commits intoneo-project:masterfrom
Conversation
Tommo-L
previously approved these changes
Aug 11, 2020
Member
|
I will close this because it has been discussed and be denied in #263. |
Contributor
Author
|
@erikzhang #263 is about the address conversion to script hash, that takes some other validations besides the base58 conversion. |
Contributor
|
|
erikzhang
reviewed
Aug 12, 2020
shargon
reviewed
Aug 12, 2020
erikzhang
previously approved these changes
Aug 12, 2020
shargon
previously approved these changes
Aug 12, 2020
Member
|
@meevee98 could you update the base branch? |
f1a3f1d to
4d11613
Compare
shargon
approved these changes
Aug 14, 2020
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Aug 23, 2020
45 tasks
7 tasks
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* base58 encode and decode interop * protected methods * coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included two new interops:
System.Binary.Base58EncodeSystem.Binary.Base58Decode