Skip to content

feat: Add an option to set act executor concurrency by cli option.#2762

Merged
mergify[bot] merged 3 commits intonektos:masterfrom
qoomon:patch-1
May 23, 2025
Merged

feat: Add an option to set act executor concurrency by cli option.#2762
mergify[bot] merged 3 commits intonektos:masterfrom
qoomon:patch-1

Conversation

@qoomon
Copy link
Contributor

@qoomon qoomon commented May 19, 2025 •
edited
Loading

Fix #2756

@mergify mergify bot added the needs-work Extra attention is needed label May 19, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 19, 2025
@qoomon
Copy link
Contributor Author

qoomon commented May 19, 2025

Need help. Can not figuring out what causes the test to fail. I does not seem to be related to the actual change

@ChristopherHX
Copy link
Contributor

ChristopherHX commented May 19, 2025

FYI I disabled test "TestRunEventHostEnvironment/defaults-run" in #2761

  1. The test is really broken
    • shell sh might be bash, but is not most of the time
  2. GitHub Hosted Runners changed
    • in docker it still passes

ChristopherHX
ChristopherHX reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of concurrency is very broken and the last time making this configurable as it currently is was rejected

  • matrix jobs have it's own independent max-parallel
  • planner slices jobs into stages
    • all jobs of a stage need to finish for dependent jobs to run
    • this is most likely a leftover from the initial GitHub Actions Alpha 2018-2019

@codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.67%. Comparing base (bd4bc99) to head (d9d3091).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/runner.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
+ Coverage   74.65%   74.67%   +0.01%     
==========================================
  Files          73       73              
  Lines       11139    11147       +8     
==========================================
+ Hits         8316     8324       +8     
  Misses       2186     2186              
  Partials      637      637

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify bot removed the needs-work Extra attention is needed label May 20, 2025
@pull-request-size pull-request-size bot added size/S and removed size/M labels May 20, 2025
@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels May 20, 2025
@qoomon
Copy link
Contributor Author

qoomon commented May 20, 2025

done. now concurrent jobs can be set by the cli parameter --concurrent-jobs

ChristopherHX
ChristopherHX reviewed May 20, 2025
View reviewed changes
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 21, 2025
@mergify mergify bot added the needs-work Extra attention is needed label May 21, 2025
@mergify mergify bot removed the needs-work Extra attention is needed label May 21, 2025
ChristopherHX
ChristopherHX approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge

@qoomon qoomon changed the title Add an option to set act executor concurrency by environment variable. feat: Add an option to set act executor concurrency by environment variable. May 21, 2025
@qoomon qoomon mentioned this pull request May 21, 2025
Closed
@qoomon
Copy link
Contributor Author

qoomon commented May 21, 2025

I'm currently working on an action to run steps in parallel instead of sequential to safe some time and money on steps with a lot of IO like browser tests. https://github.com/qoomon/actions--parallel-steps

Under the hood I use act to run each step in an own parallel job. However on 4 job can run in parallel currently.
Because I have to wait for all steps (act jobs) to finish each stage (pre, main, post) I need to run as many act jobs as parallel steps I want to execute.

Therefore I would be awesome to have this PR merged to make my action work with more jobs than just the amount of cpus of the action runner.

@qoomon
Copy link
Contributor Author

qoomon commented May 21, 2025 •
edited
Loading

BTW I you are interested in a act action, I'm happy to build and contribute the action. This action would then run a whole workflow as a step. e.g.

- uses: nektos/act@v0.2.77
  with:
    workflow: .github/workflows/test.yaml

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added the needs-work Extra attention is needed label May 23, 2025
@mergify mergify bot removed the needs-work Extra attention is needed label May 23, 2025
@mergify mergify bot merged commit 16b86a6 into nektos:master May 23, 2025
12 checks passed
@qoomon qoomon changed the title feat: Add an option to set act executor concurrency by environment variable. feat: Add an option to set act executor concurrency by cli option. Jun 6, 2025
@qoomon qoomon mentioned this pull request Jun 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristopherHX ChristopherHX ChristopherHX approved these changes

@panekj panekj panekj approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to manually set concurrent job limit.

3 participants

@qoomon @ChristopherHX @panekj