Skip to content

feat: log parsed commands and step summary#2761

Merged
mergify[bot] merged 6 commits intomasterfrom
log-parsed-commands-and-summary
Jun 1, 2025
Merged

feat: log parsed commands and step summary#2761
mergify[bot] merged 6 commits intomasterfrom
log-parsed-commands-and-summary

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented May 18, 2025

No description provided.

@ChristopherHX
feat: log parsed command data in json logger
406cfe6 
* Could be used to upload the GITHUB_STEP_SUMMARY by downstream Projects
* You can see the summary and other commands
* Access the raw line of most commands
@ChristopherHX
Update step.go
0b016cc
@ChristopherHX
Update step.go
c20838e
@ChristopherHX
Update push.yml
15b9237
@ChristopherHX
.
40d8012
@ChristopherHX ChristopherHX linked an issue May 18, 2025 that may be closed by this pull request
$GITHUB_STEP_SUMMARY is unusable for any nontrivial workflow #2273
Closed
@ChristopherHX ChristopherHX linked an issue May 18, 2025 that may be closed by this pull request
Add Command Files Content as part of the step completion events #2759
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 7 0 0.02s
✅ REPOSITORY gitleaks yes no 2.71s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.04s
✅ REPOSITORY secretlint yes no 1.24s
✅ REPOSITORY trivy-sbom yes no 0.39s
✅ REPOSITORY trufflehog yes no 4.14s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.70%. Comparing base (bd4bc99) to head (c0e6a65).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/runner/step.go 70.96% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
+ Coverage   74.65%   74.70%   +0.05%     
==========================================
  Files          73       73              
  Lines       11139    11158      +19     
==========================================
+ Hits         8316     8336      +20     
- Misses       2186     2188       +2     
+ Partials      637      634       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChristopherHX ChristopherHX mentioned this pull request May 19, 2025
Merged
@qoomon
Copy link
Contributor

qoomon commented Jun 1, 2025

Anything needed to merge this? Anything I can do to support?

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Jun 1, 2025 •
edited
Loading

A review from a maintainer is needed, but without feedback I have no idea what should be changed if anything.

@qoomon
Copy link
Contributor

qoomon commented Jun 1, 2025

@cplee could you help us out here?

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added the needs-work Extra attention is needed label Jun 1, 2025
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Jun 1, 2025 •
edited
Loading

Unbelievable the first time ever became this error persisting reruns here.

  fatal error: concurrent map iteration and map write

Maybe I need to port https://github.com/actions-oss/act-cli/pull/26 to nektos/act until CI passes...

@mergify mergify bot removed the needs-work Extra attention is needed label Jun 1, 2025
@mergify mergify bot merged commit 1154f0d into master Jun 1, 2025
20 of 22 checks passed
@mergify mergify bot deleted the log-parsed-commands-and-summary branch June 1, 2025 21:30
@ChristopherHX ChristopherHX mentioned this pull request Jun 2, 2025
Merged
@qoomon
Copy link
Contributor

qoomon commented Jun 7, 2025

looking forward for a release

@qoomon
Copy link
Contributor

qoomon commented Jun 20, 2025

@cplee when we can expect the next release including this feature?

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Jun 20, 2025

@qoomon cplee has fully automated this over a year ago, every 1st each month. Next 1st July.

@qoomon
Copy link
Contributor

qoomon commented Jul 1, 2025 •
edited
Loading

@ChristopherHX Works like a charm thank you. I've ever need to run steps in parallel now it's possible in an convenient way with my parallel-steps action thanks to this PR it's now fully functional.

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Jul 2, 2025

This is useful for me as well to customize command logging.

e.g. to print ##[group] in the log that I upload in my self-hosted runner to GitHub Actions instead of patching this implementation.

While my self-hosted runner based on act could do much more than an action, as long this does not cause UI bugs on GitHub.

e.g. Report 5 steps shown one after the other as running at the same time, while I would not know how the service will react.

project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-runner that referenced this pull request Aug 7, 2025
@ChristopherHX
feat: log parsed commands and step summary (#824)
e100e30 
Refs nektos/act#2761

---

* feat: log parsed command data in json logger

* Could be used to upload the GITHUB_STEP_SUMMARY by downstream Projects
* You can see the summary and other commands
* Access the raw line of most commands

* Update step.go

* Update step.go

* Update push.yml

* .

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit bb7db7b1c8a456d46907f3e65a6c4c2c1dcb6286)

```
Conflicts:
	act/runner/command.go
	act/runner/runner_test.go

  trivial context conflicts for both
```

<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- features
  - [PR](https://code.forgejo.org/forgejo/runner/pulls/824): <!--number 824 --><!--line 0 --><!--description ZmVhdDogbG9nIHBhcnNlZCBjb21tYW5kcyBhbmQgc3RlcCBzdW1tYXJ5-->feat: log parsed commands and step summary<!--description-->
<!--end release-notes-assistant-->

Co-authored-by: ChristopherHX <christopher.homberger@web.de>
Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/824
Reviewed-by: Gusted <gusted@noreply.code.forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cplee cplee cplee approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Command Files Content as part of the step completion events $GITHUB_STEP_SUMMARY is unusable for any nontrivial workflow

3 participants

@ChristopherHX @qoomon @cplee