Skip to content

fix: IsHost is defined as false on windows#2093

Merged
nektos-ci merged 5 commits intomasterfrom
ishost-and-isuserdefined-are-broken
Dec 16, 2023
Merged

fix: IsHost is defined as false on windows#2093
nektos-ci merged 5 commits intomasterfrom
ishost-and-isuserdefined-are-broken

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Nov 14, 2023 •
edited
Loading

Sorry the last change didn't work.

However it would be useful to not comment it works if you didn't tested it.

Maybe fixes #2074

IsHost is even defined to false on windows, the host default of act makes the docker cli/api package buggy.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.36s
✅ REPOSITORY git_diff yes no 0.17s
✅ REPOSITORY grype yes no 9.16s
✅ REPOSITORY secretlint yes no 1.08s
✅ REPOSITORY trivy-sbom yes no 0.63s
✅ REPOSITORY trufflehog yes no 15.95s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 872 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (274a246) 61.60%.
Report is 284 commits behind head on master.

Files Patch % Lines
pkg/artifactcache/handler.go 65.46% 102 Missing and 42 partials ⚠️
pkg/runner/run_context.go 73.37% 75 Missing and 19 partials ⚠️
pkg/runner/expression.go 55.17% 66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go 50.74% 49 Missing and 17 partials ⚠️
pkg/container/docker_network.go 0.00% 56 Missing ⚠️
pkg/container/docker_run.go 2.00% 48 Missing and 1 partial ⚠️
pkg/model/workflow.go 43.37% 40 Missing and 7 partials ⚠️
pkg/common/outbound_ip.go 0.00% 44 Missing ⚠️
pkg/container/host_environment.go 0.00% 43 Missing ⚠️
pkg/artifactcache/storage.go 60.22% 24 Missing and 11 partials ⚠️
... and 25 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   61.22%   61.60%   +0.38%     
==========================================
  Files          46       53       +7     
  Lines        7141     8806    +1665     
==========================================
+ Hits         4372     5425    +1053     
- Misses       2462     2950     +488     
- Partials      307      431     +124

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX ChristopherHX mentioned this pull request Nov 21, 2023
Closed
@ChristopherHX ChristopherHX marked this pull request as ready for review November 22, 2023 13:02
@ChristopherHX ChristopherHX requested a review from a team as a code owner November 22, 2023 13:02
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Nov 22, 2023

Missing Windows CI for linux Containers, change might only work on linux.

I strongly recommend to test this on a windows machine before approving it.

@RedBrumbler
Copy link

RedBrumbler commented Nov 24, 2023

I ran into the networking issue from #2074 and this PR fixes that, thanks

Act version that's broken: release 0.2.54 from choco
The artifact from this PR ran the actions for me.

@tadghh
Copy link

tadghh commented Dec 10, 2023

Any update on this? Windows users are stuck on version 0.2.51 otherwise

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Dec 15, 2023

Any update on this? Windows users are stuck on version 0.2.51 otherwise

No, I don't have permission to continue

@nektos-ci nektos-ci merged commit 1b10028 into master Dec 16, 2023
@nektos-ci nektos-ci deleted the ishost-and-isuserdefined-are-broken branch December 16, 2023 22:46
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
@ChristopherHX
fix: IsHost is defined as false on windows (nektos#2093)
999ab19 
* fix: IsHost is defined as false on windows

* Update docker_run.go

* Update docker_run.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

network-scoped alias is supported only for containers in user defined networks

4 participants

@ChristopherHX @RedBrumbler @tadghh @nektos-ci