Don't set GITHUB_TOKEN env variable#2089
Merged
mergify[bot] merged 2 commits intonektos:masterfrom Nov 12, 2023
Merged
Conversation
This needs to be explicitly in the `env` to be consistent with GitHub
e2c6994 to
7f1de6d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2089 +/- ##
==========================================
+ Coverage 61.22% 61.51% +0.29%
==========================================
Files 46 53 +7
Lines 7141 8778 +1637
==========================================
+ Hits 4372 5400 +1028
- Misses 2462 2951 +489
- Partials 307 427 +120
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
ChristopherHX
approved these changes
Nov 12, 2023
Contributor
ChristopherHX
left a comment
There was a problem hiding this comment.
I didn't notice that myself, but you are 100% correct.
For Gitea Actions this caused weird problems like GITHUB_TOKEN and GITEA_TOKEN both were defined and the action implemented an workaround to no longer throw an error in that case
cplee
approved these changes
Nov 12, 2023
jmikedupont2
pushed a commit
to meta-introspector/act
that referenced
this pull request
Mar 10, 2024
This needs to be explicitly in the `env` to be consistent with GitHub Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
chhe
pushed a commit
to chhe/act_runner
that referenced
this pull request
Mar 27, 2024
Follow https://gitea.com/gitea/act_runner/src/commit/a7eca813eae1747a7323c0e88e01b7417293ffe9/.gitea/workflows/release-tag.yml#L39 It works before unexpectedly because of nektos/act#2089 Reviewed-on: https://gitea.com/gitea/act_runner/pulls/524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to be explicitly set in the job/step/etc
envto be consistent with GitHub.Fixes #2081