Support array expressions in runs-on#2088
Merged
mergify[bot] merged 3 commits intonektos:masterfrom Nov 12, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2088 +/- ##
==========================================
+ Coverage 61.22% 61.55% +0.33%
==========================================
Files 46 53 +7
Lines 7141 8779 +1638
==========================================
+ Hits 4372 5404 +1032
- Misses 2462 2949 +487
- Partials 307 426 +119
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
jenseng
commented
Nov 11, 2023
jenseng
commented
Nov 11, 2023
ChristopherHX
approved these changes
Nov 12, 2023
Contributor
ChristopherHX
left a comment
There was a problem hiding this comment.
Looks good to me.
My idea for matrix jobs is to clone the job struct for each matrix leg, should fix a lot of side effects.
You are right matrix job polution issues are already present in act
cplee
approved these changes
Nov 12, 2023
jenseng
added a commit
to jenseng/act
that referenced
this pull request
Nov 23, 2023
Move the logging back up a level to fix a minor logging issue introduced in nektos#2088 `RunContext`s for composite actions have dummy/blank `Job`s with no `runs-on`, meaning their calls to `withGithubEnv` would result in an inaccurate log message complaining that `'runs-on' key not defined in ...`
jenseng
added a commit
to jenseng/act
that referenced
this pull request
Nov 23, 2023
Move the logging back up a level to fix a minor logging issue introduced in nektos#2088 `RunContext`s for composite actions have dummy/blank `Job`s with no `runs-on`, meaning their calls to `withGithubEnv` would result in an inaccurate log message complaining that `'runs-on' key not defined in ...`
mergify bot
added a commit
that referenced
this pull request
Dec 16, 2023
Move the logging back up a level to fix a minor logging issue introduced in #2088 `RunContext`s for composite actions have dummy/blank `Job`s with no `runs-on`, meaning their calls to `withGithubEnv` would result in an inaccurate log message complaining that `'runs-on' key not defined in ...` Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jmikedupont2
pushed a commit
to meta-introspector/act
that referenced
this pull request
Mar 10, 2024
* Support array expressions in runs-on * Simplify appproach to use EvaluateYamlNode, fix case-sensitivity bug --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
jmikedupont2
pushed a commit
to meta-introspector/act
that referenced
this pull request
Mar 10, 2024
Move the logging back up a level to fix a minor logging issue introduced in nektos#2088 `RunContext`s for composite actions have dummy/blank `Job`s with no `runs-on`, meaning their calls to `withGithubEnv` would result in an inaccurate log message complaining that `'runs-on' key not defined in ...` Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure array expressions in
runs-onare handled correctly. Also fix-Pto work case-insensitively, since labels are not case sensitive.There is still one outstanding issue with
runs-onand expressions, but that is not new to this PR: a matrix with a templated runs-on (e.g.runs-on: ${{ matrix.label }}). That feels like a bigger fix/refactor, so I was thinking of filing a new issue issue/PR for that, but if you'd prefer I can incorporate it into this one.Fixes #2080