feat: support runs-on labels and group#2062
Merged
mergify[bot] merged 2 commits intonektos:masterfrom Nov 12, 2023
Merged
Conversation
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
Contributor
Author
|
Any update on this? |
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
+ Coverage 61.22% 61.58% +0.36%
==========================================
Files 46 53 +7
Lines 7141 8807 +1666
==========================================
+ Hits 4372 5424 +1052
- Misses 2462 2951 +489
- Partials 307 432 +125
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
ChristopherHX
approved these changes
Nov 12, 2023
Contributor
ChristopherHX
left a comment
There was a problem hiding this comment.
Thank you for implementing this,
Yes act should support this, but another maintainer or the owner need to approve too
cplee
approved these changes
Nov 12, 2023
jmikedupont2
pushed a commit
to meta-introspector/act
that referenced
this pull request
Mar 10, 2024
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com> Co-authored-by: ChristopherHX <christopher.homberger@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
act does not work with our worklfow declarations which are as follow:
acts
runs-ononly supports a string or or a string slice. However the github workflow schema does support group and labels keys.See https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/github-workflow.json#L703-L721 for reference.
Proposal
This pr actually supports this use case. It will just combine labels and optional group declarations in the runs on output slice. This should be suitable for cover use cases for custom images targeting these labels.