Skip to content

Interpolate all service values#2054

Merged
mergify[bot] merged 2 commits intomasterfrom
interpolate-services
Nov 12, 2023
Merged

Interpolate all service values#2054
mergify[bot] merged 2 commits intomasterfrom
interpolate-services

Conversation

@ZauberNerd
Copy link
Contributor

@ZauberNerd ZauberNerd commented Oct 19, 2023 •
edited
Loading

Continuation from #1949 (comment)

@ZauberNerd ZauberNerd requested a review from a team as a code owner October 19, 2023 14:15
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.02s
✅ REPOSITORY gitleaks yes no 2.35s
✅ REPOSITORY git_diff yes no 0.17s
✅ REPOSITORY grype yes no 6.76s
✅ REPOSITORY secretlint yes no 0.95s
✅ REPOSITORY trivy-sbom yes no 0.6s
✅ REPOSITORY trufflehog yes no 15.96s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

@ZauberNerd this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Oct 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@ZauberNerd this pull request has failed checks 🛠

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@ZauberNerd this pull request has failed checks 🛠

@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #2054 (67dc24c) into master (4989f44) will increase coverage by 0.24%.
Report is 270 commits behind head on master.
The diff coverage is 59.89%.

@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
+ Coverage   61.22%   61.47%   +0.24%     
==========================================
  Files          46       53       +7     
  Lines        7141     8788    +1647     
==========================================
+ Hits         4372     5402    +1030     
- Misses       2462     2957     +495     
- Partials      307      429     +122
Files Coverage Δ
pkg/common/executor.go 51.69% <100.00%> (+1.69%) ⬆️
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/runner/step_action_local.go 93.54% <100.00%> (ø)
pkg/runner/step_action_remote.go 91.56% <100.00%> (+0.65%) ⬆️
pkg/runner/step_docker.go 93.18% <100.00%> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/container/docker_build.go 60.00% <80.00%> (+1.02%) ⬆️
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
... and 31 more

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mergify mergify bot removed the needs-work Extra attention is needed label Oct 20, 2023
ChristopherHX
ChristopherHX approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please also have a look at #2075.

We currently have a windows only regression in act

@mergify mergify bot merged commit c8f847d into master Nov 12, 2023
@mergify mergify bot deleted the interpolate-services branch November 12, 2023 18:30
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
@ZauberNerd @mergify
Evaluate all service values (nektos#2054)
e7c3560 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cplee cplee cplee approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZauberNerd @cplee @ChristopherHX