This repository was archived by the owner on Sep 29, 2023. It is now read-only.
squirrel: resolve .quit() issue with missing ../screen#784
Merged
Conversation
* As explained in: electron/electron#8862 (comment) an issue with .quit() exists with a "Cannot find module '../screen'" issue, while using the .exit() alternative avoids the issue
Contributor
|
@AdrianDC sure! Thanks! Merging. |
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…#784) * As explained in: electron/electron#8862 (comment) an issue with .quit() exists with a "Cannot find module '../screen'" issue, while using the .exit() alternative avoids the issue * Validated on Windows with the same logic as nativefier#744 where the issue recently appeared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in: Cannot find module '../screen' electron/electron#8862 (comment)
an issue with .quit() exists with a "Cannot find module '../screen'" issue,
while using the .exit() alternative avoids the issue
Validated on Windows with the same logic as Support packaging nativefier applications into Squirrel-based installers #744 where the issue recently appeared