This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Maximize window visual glitch on Windows fix (fix #1447)#1448
Merged
Conversation
Contributor
|
@Adam777Z hi and thanks for the PR. Can you precise what you mean by "glitch"? A precise description or screenshot/screencast would be welcome. Also, glitch or not, your PR is a functional regression, and will I think annoy users used to the current behavior. I think I'd rather keep the glitch but honor the desired behavior. Waddayathink? |
Contributor
Author
|
This is only a temporary fix until it's fixed in Electron. There's no change in functionality, it works as before, just without the visual glitch on Windows. This change is for Windows only. You can test this easily on Windows:
|
5 tasks
ronjouch
approved these changes
Nov 7, 2022
Adam777Z
added a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…nativefier#1448) Fix for [Maximize window visual glitch on Windows · Issue nativefier#1447 · nativefier/nativefier](nativefier#1447) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
Adam777Z
added a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…nativefier#1448) Fix for [Maximize window visual glitch on Windows · Issue nativefier#1447 · nativefier/nativefier](nativefier#1447) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Maximize window visual glitch on Windows · Issue #1447 · nativefier/nativefier