This repository was archived by the owner on Sep 29, 2023. It is now read-only.
macOS: Move handling of "universal" apps to electron-packager instead of our own thing#1443
Merged
ronjouch merged 3 commits intoAug 2, 2022
Conversation
Contributor
|
Dope, thanks Adam. Merged. I reverted the yellow log; I think it might not fare well under atypical terminal color configs. The current thing, a large block with surrounding newlines, is already quite visible. |
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
… of our own thing (nativefier#1443) Supported since [electron-packager 15.5.0](https://github.com/electron/electron-packager/releases/tag/v15.5.0). This should fix nativefier#1405 as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supported since electron-packager 15.5.0.
This should fix #1405 as well