Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Update axios to latest#4

Merged
ronjouch merged 1 commit into
nativefier:masterfrom
TheCleric:fix/older_packages
Jul 30, 2022
Merged

Update axios to latest#4
ronjouch merged 1 commit into
nativefier:masterfrom
TheCleric:fix/older_packages

Conversation

@TheCleric

@TheCleric TheCleric commented Jul 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@ronjouch

Axios at this version is throwing a warning for me downstream in nativefier:

(node:46090) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
    at emitExperimentalWarning (node:internal/util:224:11)
    at lazyUndici (node:internal/bootstrap/pre_execution:188:5)
    at get (node:internal/bootstrap/pre_execution:204:16)
    at Object.isFormData (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/utils.js:57:3)
    at Object.transformRequest (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/defaults.js:58:15)
    at transform (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/core/transformData.js:18:15)
    at Object.forEach (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/utils.js:245:10)
    at Object.transformData (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/core/transformData.js:17:9)
    at dispatchRequest (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/core/dispatchRequest.js:30:31)
    at Axios.request (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/core/Axios.js:108:15)
    at Axios.<computed> [as get] (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/core/Axios.js:129:17)
    at Function.wrap [as get] (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/node_modules/axios/lib/helpers/bind.js:9:15)
    at gitCloud (/Users/me/Dev/personal/nativefier/node_modules/gitcloud/gitcloud.js:5:16)
    at inferIconFromStore (/Users/me/Dev/personal/nativefier/src/infer/inferIcon.ts:77:28)
    at inferIcon (/Users/me/Dev/personal/nativefier/src/infer/inferIcon.ts:109:11)
    at icon (/Users/me/Dev/personal/nativefier/src/options/fields/icon.ts:25:27)

@ronjouch

ronjouch commented Jul 30, 2022

Copy link
Copy Markdown
Contributor

Uh? Okay, didn't know Axios would sometimes call fetch behind the scenes. And I guess they recently improved since then how they handle it, to no longer show these warnings. Okay, merging, will cut a release and bump in Nativefier soon.

@ronjouch ronjouch merged commit 4d5dac3 into nativefier:master Jul 30, 2022
ronjouch added a commit to nativefier/nativefier that referenced this pull request Jul 30, 2022
@ronjouch
Relock deps to get gitcloud 0.2.4 with "fetch" log fix
b362fbe 
nativefier/gitcloud-client#4
Adam777Z pushed a commit to Adam777Z/nativefier that referenced this pull request Nov 9, 2022
@ronjouch
Relock deps to get gitcloud 0.2.4 with "fetch" log fix
a81360c 
nativefier/gitcloud-client#4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ronjouch ronjouch ronjouch approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheCleric @ronjouch