Conversation
|
@LeStarch / @bocchino This PR breaks some of the examples since the |
Yes, you should create a PR to the fprime-examples repo with the fix and with following magic prefix in its branch name: |
|
@Kronos3 for the |
|
@thomas-bc when you have a moment, please review w.r.t the com pipeline stuff. |
| @ Communication adapter interface implementing communication adapter interface via a Drv.ByteStreamDriverModel. | ||
| passive component ComStub { | ||
| include "../Interfaces/ComInterface.fppi" | ||
| import Com |
There was a problem hiding this comment.
Is there a plan to have a keyword specific to implementing an interface in the future? It's not immediately clear to the reader what import Com does if there's no annotation.
Just a thought, not saying we should add comments everywhere.
There was a problem hiding this comment.
We are not planning on adding any syntax to denote implementing an interface besides the import. But yes I agree it's not immediately obvious that import is implementing the interface.
|
Reminder: need to merge nasa/fprime-examples#11 when (ideally right before) merging this PR here. |
This PR puts true FPP interfaces in place of our
include "../../[...].fppi"Closes nasa/fpp#702
Depends on nasa/fpp#736
TODO