Merged
Conversation
Collaborator
Author
|
@bocchino Should we add a test for this? I think it'll be some sort of cross tool check since we need to generate the locs and then parse it. It'll also always be caught by the Fprime core integration so it may not be 100% necessary. |
Collaborator
|
Looks good, but it seems we never added a test for interface dependencies to fpp-depend. Can you add one here? https://github.com/nasa/fpp/tree/main/compiler/tools/fpp-depend/test |
Collaborator
Author
|
Ah good point, I've updated some tests to validate this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this issue which working on #702. The generated locs file could not be parsed back into the model since I didn't update the parser. This was the only FPP change required to get FppTest passing